change CompileError to ArgumentError. Update error message

Author: jwharrow

lib/elixir/lib/inspect.ex

@@ -455,8 +455,8 @@ defimpl Inspect, for: Any do
     only = Keyword.get(options, :only, fields)
     except = Keyword.get(options, :except, [])
 
-    :ok = validate_option(only, fields, module, __CALLER__)
-    :ok = validate_option(except, fields, module, __CALLER__)
+    :ok = validate_option(only, fields, module)
+    :ok = validate_option(except, fields, module)
 
     filtered_fields =
       fields
@@ -481,13 +481,15 @@ defimpl Inspect, for: Any do
     end
   end
 
-  defp validate_option(option_list, fields, module, caller) do
-    if not Enum.empty?(option_list -- fields) do
-      description = "When deriving inspect protocol of #{module}, values must match struct fields"
-      raise CompileError, file: caller.file, line: caller.line, description: description
-    end
+  defp validate_option(option_list, fields, module) do
+    case option_list -- fields do
+      [] ->
+        :ok
 
-    :ok
+      unknown_fields ->
+        raise ArgumentError,
+              "unknown fields #{Kernel.inspect(unknown_fields)} given when deriving the Inspect protocol for #{Kernel.inspect(module)}. :only and :except values must match struct fields"
+    end
   end
 
   def inspect(%module{} = struct, opts) do

lib/elixir/test/elixir/inspect_test.exs

@@ -695,27 +695,25 @@ defmodule Inspect.MapTest do
   end
 
   test "struct missing fields in the :only option" do
-    message =
-      ~r"When deriving inspect protocol of Elixir.Inspect.MapTest.StructMissingFieldsInOnlyOption, values must match struct fields"
-
-    assert_raise CompileError, message, fn ->
-      defmodule StructMissingFieldsInOnlyOption do
-        @derive {Inspect, only: [:c]}
-        defstruct [:a, :b]
-      end
-    end
+    assert_raise ArgumentError,
+                 "unknown fields [:c] given when deriving the Inspect protocol for Inspect.MapTest.StructMissingFieldsInOnlyOption. :only and :except values must match struct fields",
+                 fn ->
+                   defmodule StructMissingFieldsInOnlyOption do
+                     @derive {Inspect, only: [:c]}
+                     defstruct [:a, :b]
+                   end
+                 end
   end
 
   test "struct missing fields in the :except option" do
-    message =
-      ~r"When deriving inspect protocol of Elixir.Inspect.MapTest.StructMissingFieldsInExceptOption, values must match struct fields"
-
-    assert_raise CompileError, message, fn ->
-      defmodule StructMissingFieldsInExceptOption do
-        @derive {Inspect, except: [:c]}
-        defstruct [:a, :b]
-      end
-    end
+    assert_raise ArgumentError,
+                 "unknown fields [:c, :d] given when deriving the Inspect protocol for Inspect.MapTest.StructMissingFieldsInExceptOption. :only and :except values must match struct fields",
+                 fn ->
+                   defmodule StructMissingFieldsInExceptOption do
+                     @derive {Inspect, except: [:c, :d]}
+                     defstruct [:a, :b]
+                   end
+                 end
   end
 
   defmodule StructWithExceptOption do