Skip to content

Commit d44617a

Browse files
author
Philip Sampaio
committed
Use the more common array declaration
1 parent 9715b36 commit d44617a

File tree

1 file changed

+42
-42
lines changed

1 file changed

+42
-42
lines changed

bin/elixir.ps1

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ function QuoteString {
103103
}
104104
}
105105

106-
$elixirParams = New-Object Collections.Generic.List[String]
107-
$erlangParams = New-Object Collections.Generic.List[String]
108-
$beforeExtras = New-Object Collections.Generic.List[String]
109-
$allOtherParams = New-Object Collections.Generic.List[String]
106+
$elixirParams = @()
107+
$erlangParams = @()
108+
$beforeExtras = @()
109+
$allOtherParams = @()
110110

111111
$runErlPipe = $null
112112
$runErlLog = $null
@@ -118,66 +118,66 @@ for ($i = 0; $i -lt $args.Count; $i++) {
118118
{ $_ -in @("-e", "-r", "-pr", "-pa", "-pz", "--eval", "--remsh", "--dot-iex", "--dbg") } {
119119
$private:nextArg = NormalizeArg($args[++$i])
120120

121-
$elixirParams.Add($arg)
122-
$elixirParams.Add($nextArg)
121+
$elixirParams += $arg
122+
$elixirParams += $nextArg
123123

124124
break
125125
}
126126

127127
{ $_ -in @("-v", "--version") } {
128128
# Standalone options goes only once in the Elixir params, when they are empty.
129129
if (($elixirParams.Count -eq 0) -and ($allOtherParams.Count -eq 0)) {
130-
$elixirParams.Add($arg)
130+
$elixirParams += $arg
131131
}
132132
else {
133-
$allOtherParams.Add($arg)
133+
$allOtherParams += $arg
134134
}
135135
break
136136
}
137137

138138
"--no-halt" {
139-
$elixirParams.Add($arg)
139+
$elixirParams += $arg
140140
break
141141
}
142142

143143
"--cookie" {
144-
$erlangParams.Add("-setcookie")
145-
$erlangParams.Add($args[++$i])
144+
$erlangParams += "-setcookie"
145+
$erlangParams += $args[++$i]
146146
break
147147
}
148148

149149
"--hidden" {
150-
$erlangParams.Add("-hidden")
150+
$erlangParams += "-hidden"
151151
break
152152
}
153153

154154
"--name" {
155-
$erlangParams.Add("-name")
156-
$erlangParams.Add($args[++$i])
155+
$erlangParams += "-name"
156+
$erlangParams += $args[++$i]
157157
break
158158
}
159159

160160
"--sname" {
161-
$erlangParams.Add("-sname")
162-
$erlangParams.Add($args[++$i])
161+
$erlangParams += "-sname"
162+
$erlangParams += $args[++$i]
163163
break
164164
}
165165

166166
"--boot" {
167-
$erlangParams.Add("-boot")
168-
$erlangParams.Add($args[++$i])
167+
$erlangParams += "-boot"
168+
$erlangParams += $args[++$i]
169169
break
170170
}
171171

172172
"--erl-config" {
173-
$erlangParams.Add("-config")
174-
$erlangParams.Add($args[++$i])
173+
$erlangParams += "-config"
174+
$erlangParams += $args[++$i]
175175
break
176176
}
177177

178178
"--vm-args" {
179-
$erlangParams.Add("-args_file")
180-
$erlangParams.Add($args[++$i])
179+
$erlangParams += "-args_file"
180+
$erlangParams += $args[++$i]
181181
break
182182
}
183183

@@ -199,19 +199,19 @@ for ($i = 0; $i -lt $args.Count; $i++) {
199199

200200
"--erl" {
201201
$private:erlFlags = $args[++$i] -split " "
202-
$beforeExtras.AddRange($erlFlags)
202+
$beforeExtras += $erlFlags
203203
break
204204
}
205205

206206
"+iex" {
207-
$elixirParams.Add("+iex")
207+
$elixirParams += "+iex"
208208
$useIex = $true
209209

210210
break
211211
}
212212

213213
"+elixirc" {
214-
$elixirParams.Add("+elixirc")
214+
$elixirParams += "+elixirc"
215215
break
216216
}
217217

@@ -229,9 +229,9 @@ for ($i = 0; $i -lt $args.Count; $i++) {
229229
exit 1
230230
}
231231

232-
$elixirParams.Add("--rpc-eval")
233-
$elixirParams.Add($key)
234-
$elixirParams.Add($value)
232+
$elixirParams += "--rpc-eval"
233+
$elixirParams += $key
234+
$elixirParams += $value
235235
break
236236
}
237237

@@ -249,9 +249,9 @@ for ($i = 0; $i -lt $args.Count; $i++) {
249249
exit 1
250250
}
251251

252-
$elixirParams.Add("-boot_var")
253-
$elixirParams.Add($key)
254-
$elixirParams.Add($value)
252+
$elixirParams += "-boot_var"
253+
$elixirParams += $key
254+
$elixirParams += $value
255255
break
256256
}
257257

@@ -279,37 +279,37 @@ for ($i = 0; $i -lt $args.Count; $i++) {
279279

280280
Default {
281281
$private:normalized = NormalizeArg $arg
282-
$allOtherParams.Add($normalized)
282+
$allOtherParams += $normalized
283283
break
284284
}
285285
}
286286
}
287287

288288
if ($null -eq $useIEx) {
289-
$beforeExtras.InsertRange(0, [string[]]@("-s", "elixir", "start_cli"))
289+
$beforeExtras = @("-s", "elixir", "start_cli") + $beforeExtras
290290
}
291291

292-
$beforeExtras.InsertRange(0, [string[]]@("-pa", "$(Join-Path $scriptPath -ChildPath "../lib/elixir/ebin")"))
293-
$beforeExtras.InsertRange(0, [string[]]@("-noshell", "-elixir_root", "$(Join-Path $scriptPath -ChildPath "../lib")"))
292+
$beforeExtras = @("-pa", "$(Join-Path $scriptPath -ChildPath "../lib/elixir/ebin")") + $beforeExtras
293+
$beforeExtras = @("-noshell", "-elixir_root", "$(Join-Path $scriptPath -ChildPath "../lib")") + $beforeExtras
294294

295295
# One MAY change ERTS_BIN= but you MUST NOT change
296296
# ERTS_BIN=$ERTS_BIN as it is handled by Elixir releases.
297297
# TODO: change when we port the releases scripts.
298298
# $ERTS_BIN=
299299
$ERTS_BIN = "$env:ERTS_BIN"
300300

301-
$allParams = New-Object Collections.Generic.List[String]
301+
$allParams = @()
302302

303303
if ($null -ne $env:ELIXIR_ERL_OPTIONS) {
304304
$private:erlFlags = $env:ELIXIR_ERL_OPTIONS -split " "
305-
$allParams.AddRange($erlFlags)
305+
$allParams += $erlFlags
306306
}
307307

308-
$allParams.AddRange($erlangParams)
309-
$allParams.AddRange($beforeExtras)
310-
$allParams.Add("-extra")
311-
$allParams.AddRange($elixirParams)
312-
$allParams.AddRange($allOtherParams)
308+
$allParams += $erlangParams
309+
$allParams += $beforeExtras
310+
$allParams += "-extra"
311+
$allParams += $elixirParams
312+
$allParams += $allOtherParams
313313

314314
$binSuffix = ""
315315

0 commit comments

Comments
 (0)