Generate different tmp_dir for parameterized tests

Author: josevalim

lib/ex_unit/lib/ex_unit/runner.ex

@@ -591,8 +591,10 @@ defmodule ExUnit.Runner do
     tags
   end
 
-  defp short_hash(module, test_name) do
-    (module <> "/" <> test_name)
+  defp short_hash(module, test_name, parameters) do
+    suffix = if parameters == %{}, do: "", else: :erlang.term_to_binary(parameters)
+
+    (module <> "/" <> test_name <> suffix)
     |> :erlang.md5()
     |> Base.encode16(case: :lower)
     |> binary_slice(0..7)
@@ -604,7 +606,7 @@ defmodule ExUnit.Runner do
 
     module = escape_path(module_string)
     name = escape_path(name_string)
-    short_hash = short_hash(module_string, name_string)
+    short_hash = short_hash(module_string, name_string, test.parameters)
 
     path = ["tmp", module, "#{name}-#{short_hash}", extra_path] |> Path.join() |> Path.expand()
     File.rm_rf!(path)

lib/ex_unit/test/ex_unit_test.exs

@@ -684,10 +684,14 @@ defmodule ExUnitTest do
   end
 
   test "parameterized tests" do
+    Process.register(self(), :parameterized_tests)
+
     defmodule ParameterizedTests do
       use ExUnit.Case, async: true, parameterize: [%{value: true}, %{value: false}]
 
-      test "hello world", %{value: value} do
+      @tag :tmp_dir
+      test "hello world", %{value: value, tmp_dir: tmp_dir} do
+        send(:parameterized_tests, {:tmp_dir, tmp_dir})
         assert value
       end
     end
@@ -696,15 +700,19 @@ defmodule ExUnitTest do
 
     output = capture_io(fn -> ExUnit.run() end)
 
-    assert output =~ """
-           ExUnitTest.ParameterizedTests [test/ex_unit_test.exs]
-           Parameters: %{value: false}
+    assert output =~ ~r"""
+           ExUnitTest.ParameterizedTests \[.*test/ex_unit_test.exs\]
+           Parameters: %\{value: false\}
            """
 
     assert output =~ """
              1) test hello world (ExUnitTest.ParameterizedTests)
                 Parameters: %{value: false}
            """
+
+    # Check that the temporary paths are different
+    assert_receive {:tmp_dir, tmp_dir1}
+    assert_receive {:tmp_dir, tmp_dir2} when tmp_dir1 != tmp_dir2
   end
 
   describe "after_suite/1" do