Port custom exceptions to ArgumentError

Those exceptions are not meant to be rescued,
so there is no benefit into providing a custom
module for them.

Author: josevalim

lib/ex_unit/lib/ex_unit/callbacks.ex

@@ -757,7 +757,7 @@ defmodule ExUnit.Callbacks do
         raise ArgumentError, "describe name must be a string, got: #{inspect(message)}"
 
       is_map_key(used_describes, message) ->
-        raise ExUnit.DuplicateDescribeError,
+        raise ArgumentError,
               "describe #{inspect(message)} is already defined in #{inspect(module)}"
 
       true ->

lib/ex_unit/lib/ex_unit/case.ex

@@ -1,26 +1,3 @@
-defmodule ExUnit.DuplicateTestError do
-  @moduledoc """
-  Exception raised to indicate two or more tests with the same name.
-  """
-
-  @typedoc since: "1.16.0"
-  @type t :: %__MODULE__{message: String.t()}
-
-  defexception [:message]
-end
-
-defmodule ExUnit.DuplicateDescribeError do
-  @moduledoc """
-  Exception raised to indicate two or more `describe` blocks with
-  the same name.
-  """
-
-  @typedoc since: "1.16.0"
-  @type t :: %__MODULE__{message: String.t()}
-
-  defexception [:message]
-end
-
 defmodule ExUnit.Case do
   @moduledoc """
   Helpers for defining test cases.
@@ -614,7 +591,7 @@ defmodule ExUnit.Case do
       end
 
     if Module.defines?(mod, {name, 1}) do
-      raise ExUnit.DuplicateTestError, ~s("#{name}" is already defined in #{inspect(mod)})
+      raise ArgumentError, ~s("#{name}" is already defined in #{inspect(mod)})
     end
 
     tags =

lib/ex_unit/test/ex_unit/describe_test.exs

@@ -86,7 +86,7 @@ defmodule ExUnit.DescribeTest do
       message =
         ~s(describe "some tests" is already defined in ExUnit.DescribeTest.DescribeWithSameNames)
 
-      assert_raise ExUnit.DuplicateDescribeError, message, fn ->
+      assert_raise ArgumentError, message, fn ->
         defmodule DescribeWithSameNames do
           use ExUnit.Case
 

lib/ex_unit/test/ex_unit_test.exs

@@ -431,7 +431,7 @@ defmodule ExUnitTest do
   test "raises friendly error for duplicate test names" do
     message = ~S("test duplicate" is already defined in ExUnitTest.TestWithSameNames)
 
-    assert_raise ExUnit.DuplicateTestError, message, fn ->
+    assert_raise ArgumentError, message, fn ->
       defmodule TestWithSameNames do
         use ExUnit.Case