Automatically detect when to warn on import

Author: José Valim

lib/elixir/lib/protocol.ex

@@ -30,7 +30,7 @@ defmodule Protocol do
         ]
 
         # Import the new dsl that holds the new def
-        import :macros, Protocol.DSL, warn: false
+        import :macros, Protocol.DSL
 
         # Set up a clear slate to store defined functions
         @functions []

lib/elixir/lib/record.ex

@@ -29,7 +29,7 @@ defmodule Record do
     quote do
       defmodule unquote(name) do
         @moduledoc false
-        import Record.DSL, warn: false
+        import Record.DSL
 
         @record_fields []
         @record_types  []

lib/elixir/src/elixir_import.erl

@@ -26,15 +26,20 @@ record(Tuple, Receiver, Module) ->
     error:badarg -> false
   end.
 
-record_warn(_Meta, _Ref, _Opts, nil) -> false;
+record_warn(_Meta, _Ref, _Opts, #elixir_scope{module=nil}) -> false;
 
-record_warn(Meta, Ref, Opts, Module) ->
-  Table = table(Module),
+record_warn(Meta, Ref, Opts, S) ->
+  Table = table(S#elixir_scope.module),
   ets:delete(Table, Ref),
-  case keyfind(warn, Opts) of
-    { warn, false } -> false;
-    false -> ets:insert(Table, { Ref, ?line(Meta) })
-  end.
+
+  Warn =
+    case keyfind(warn, Opts) of
+      { warn, false } -> false;
+      { warn, true } -> true;
+      false -> S#elixir_scope.check_clauses
+    end,
+
+  Warn andalso ets:insert(Table, { Ref, ?line(Meta) }).
 
 recorded_locals(Module) ->
   Table  = table(Module),
@@ -72,7 +77,7 @@ import(Meta, Ref, Opts, Selector, S) ->
       SF#elixir_scope{macros=Macros, macro_macros=TempM}
   end,
 
-  record_warn(Meta, Ref, Opts, S#elixir_scope.module),
+  record_warn(Meta, Ref, Opts, S),
   SM.
 
 %% IMPORT FUNCTION RELATED HELPERS

lib/elixir/src/elixir_macros.erl

@@ -213,7 +213,7 @@ translate({defmodule, Meta, [Ref, KV]}, S) ->
       { TRef, S }
   end,
 
-  MS = FS#elixir_scope{check_clauses=true,local=nil},
+  MS = FS#elixir_scope{local=nil},
   { elixir_module:translate(Meta, FRef, Block, MS), FS };
 
 translate({Kind, Meta, [Call]}, S) when ?FUNS(Kind) ->

lib/ex_unit/lib/ex_unit/callbacks.ex

@@ -47,7 +47,7 @@ defmodule ExUnit.Callbacks do
       @exunit_teardown_all []
 
       @before_compile unquote(__MODULE__)
-      import unquote(__MODULE__), warn: false
+      import unquote(__MODULE__)
 
       def __exunit__(:parent) do
         unquote(parent)

lib/ex_unit/lib/ex_unit/case.ex

@@ -38,9 +38,9 @@ defmodule ExUnit.Case do
 
       use ExUnit.Callbacks, parent: unquote(parent)
 
-      import ExUnit.Assertions, warn: false
-      import ExUnit.Case, warn: false
-      import ExUnit.DocTest, only: [doctest: 1, doctest: 2], warn: false
+      import ExUnit.Assertions
+      import ExUnit.Case
+      import ExUnit.DocTest, only: [doctest: 1, doctest: 2]
     end
   end