Skip to content

Commit 654cd77

Browse files
committed
Simplify function kind check in elixir_def_overridable.erl
1 parent 881c2d6 commit 654cd77

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

lib/elixir/src/elixir_def_overridable.erl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ store(Module, Function, GenerateName) ->
5151
Location, {Defaults, _HasBody, _LastDefaults}}, Clauses} = Clause,
5252

5353
{FinalKind, FinalName, FinalArity} =
54-
case {GenerateName, Kind} of
55-
{false, _} ->
54+
case GenerateName of
55+
false ->
5656
{Kind, Name, Arity};
57-
{true, K} when K == defmacro; K == defmacrop ->
57+
true when Kind == defmacro; Kind == defmacrop ->
5858
{defp, elixir_utils:macro_name(name(Function, Count)), Arity + 1};
59-
{true, K} when K == def; K == defp ->
59+
true when Kind == def; Kind == defp ->
6060
{defp, name(Function, Count), Arity}
6161
end,
6262

lib/elixir/test/elixir/kernel/with_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ defmodule Kernel.WithTest do
7575
end
7676
end
7777

78-
test "invalid else form" do
78+
test "invalid else option" do
7979
assert_raise CompileError, "nofile:1: expected -> clauses for else in with", fn ->
8080
Code.eval_quoted(quote do: with(_ <- true, do: :ok, else: :error))
8181
end

lib/mix/lib/mix/tasks/loadpaths.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ defmodule Mix.Tasks.Loadpaths do
1818
"""
1919

2020
@spec run(OptionParser.argv) :: :ok
21-
2221
def run(args) do
2322
config = Mix.Project.config
2423

0 commit comments

Comments
 (0)