Fix Rebar3 env var with spaces (#13303)

Author: josevalim

lib/mix/lib/mix/rebar.ex

@@ -36,7 +36,7 @@ defmodule Mix.Rebar do
   @doc """
   Returns the path to the available `rebar` command.
   """
-  # TODO: Remove on Elixir v1.18 because phx_new and other installers rely on it.
+  # TODO: Remove on Elixir v1.20 because phx_new and other installers rely on it.
   def rebar_cmd(:rebar) do
     Mix.shell().error("[warning] :rebar is no longer supported in Mix, falling back to :rebar3")
     rebar_cmd(:rebar3)
@@ -218,7 +218,7 @@ defmodule Mix.Rebar do
   defp wrap_cmd(rebar) do
     cond do
       not match?({:win32, _}, :os.type()) ->
-        rebar
+        String.replace(rebar, " ", "\\ ")
 
       String.ends_with?(rebar, ".cmd") ->
         "\"#{String.replace(rebar, "/", "\\")}\""

lib/mix/lib/mix/tasks/deps.compile.ex

@@ -207,7 +207,7 @@ defmodule Mix.Tasks.Deps.Compile do
       {"TERM", "dumb"}
     ]
 
-    cmd = "#{escape_path(rebar_cmd(dep))} bare compile --paths #{escape_path(lib_path)}"
+    cmd = "#{rebar_cmd(dep)} bare compile --paths #{escape_path(lib_path)}"
     do_command(dep, config, cmd, false, env)
 
     # Check if we have any new symlinks after compilation

lib/mix/test/mix/rebar_test.exs

@@ -219,7 +219,7 @@ defmodule Mix.RebarTest do
     # We run only on Unix because Windows has a hard time
     # removing the Rebar executable after executed.
     @tag :unix
-    test "applies variables from :system_env option when compiling dependencies" do
+    test "applies variables from :system_env option on config/compilation" do
       in_tmp("applies variables from system_env", fn ->
         Mix.Project.push(RebarAsDepWithEnv)
 
@@ -233,6 +233,27 @@ defmodule Mix.RebarTest do
       end)
     end
 
+    # We run only on Unix because Windows has a hard time
+    # removing the Rebar executable after executed.
+    @tag :unix
+    test "gets and compiles dependencies with MIX_REBAR3 with spaces" do
+      in_tmp("rebar3 env with spaces", fn ->
+        File.cp!(Mix.Rebar.local_rebar_path(:rebar3), "rebar3")
+        System.put_env("MIX_REBAR3", Path.absname("rebar3"))
+        assert Mix.Rebar.rebar_cmd(:rebar3) =~ " "
+
+        Mix.Project.push(RebarAsDep)
+        Mix.Tasks.Deps.Get.run([])
+        assert_received {:mix_shell, :info, ["* Getting git_rebar " <> _]}
+
+        Mix.Tasks.Deps.Compile.run([])
+        assert_received {:mix_shell, :run, ["===> Compiling git_rebar\n"]}
+        assert_received {:mix_shell, :run, ["===> Compiling rebar_dep\n"]}
+      end)
+    after
+      System.delete_env("MIX_REBAR3")
+    end
+
     test "gets and compiles dependencies with Mix" do
       in_tmp("get and compile dependencies with Mix", fn ->
         Mix.Project.push(RebarAsDep)