Refactor an assertion in Kernel.OverridableTest

This test was using an arcane dance to assert that some code would raise
an exception (with try/rescue, flunk, and so on) and using
:elixir.eval/2 as well; these remains of ancient times have been
replaced with Code.eval_string/1 and assert_raise/3 for more modern
Elixir code.

Author: whatyouhide

lib/elixir/test/elixir/kernel/overridable_test.exs

@@ -172,14 +172,17 @@ defmodule Kernel.OverridableTest do
   end
 
   test "invalid super call" do
-    try do
-      :elixir.eval 'defmodule Foo.Forwarding do\ndef bar, do: 1\ndefoverridable [bar: 0]\ndef foo, do: super()\nend', []
-      flunk "expected eval to fail"
-    rescue
-      error ->
-        assert Exception.message(error) ==
-          "nofile:4: no super defined for foo/0 in module Foo.Forwarding. " <>
-          "Overridable functions available are: bar/0"
+    message =
+      "nofile:4: no super defined for foo/0 in module Foo.Forwarding. " <>
+      "Overridable functions available are: bar/0"
+    assert_raise CompileError, message, fn ->
+      Code.eval_string """
+      defmodule Foo.Forwarding do
+        def bar(), do: 1
+        defoverridable bar: 0
+        def foo(), do: super()
+      end
+      """
     end
   end