Fix for OTP26-

Author: sabiwara

lib/mix/lib/mix/tasks/profile.tprof.ex

@@ -221,51 +221,58 @@ defmodule Mix.Tasks.Profile.Tprof do
     return_value
   end
 
-  defp profile_and_analyse(fun, opts) do
-    if Keyword.get(opts, :warmup, true) do
-      IO.puts("Warmup...\n")
-      fun.()
-    end
-
-    :tprof.start()
-    matching = Keyword.get(opts, :matching, {:_, :_, :_})
-    set_on_spawn = Keyword.get(opts, :set_on_spawn, true)
-    type = Keyword.get(opts, :type, :time)
-
-    sort_by =
-      case Keyword.get(opts, :sort) do
-        nil -> :measurement
-        :calls -> :calls
-        ^type -> :measurement
-        other -> Mix.raise("Incompatible sort option `#{other}` with type `#{type}`")
+  # TODO remove once we require Erlang/OTP 27+
+  if System.otp_release() >= "27" do
+    defp profile_and_analyse(fun, opts) do
+      if Keyword.get(opts, :warmup, true) do
+        IO.puts("Warmup...\n")
+        fun.()
       end
 
-    tprof_type = to_tprof_type(type)
-
-    {return_value, {^tprof_type, traces}} =
-      :tprof.profile(fun, %{
-        set_on_spawn: set_on_spawn,
-        pattern: matching,
-        type: tprof_type,
-        report: :return
-      })
-
-    inspected = :tprof.inspect({tprof_type, traces}, :process, sort_by)
-
-    :tprof.stop()
-
-    results =
-      inspected
-      |> Enum.map(fn {pid, {^tprof_type, measurement_total, call_results}} ->
-        parsed_calls =
-          call_results
-          |> filter_results(type, opts)
-          |> add_totals(measurement_total)
-
-        {pid, parsed_calls}
-      end)
-
-    {type, return_value, results}
+      :tprof.start()
+      matching = Keyword.get(opts, :matching, {:_, :_, :_})
+      set_on_spawn = Keyword.get(opts, :set_on_spawn, true)
+      type = Keyword.get(opts, :type, :time)
+
+      sort_by =
+        case Keyword.get(opts, :sort) do
+          nil -> :measurement
+          :calls -> :calls
+          ^type -> :measurement
+          other -> Mix.raise("Incompatible sort option `#{other}` with type `#{type}`")
+        end
+
+      tprof_type = to_tprof_type(type)
+
+      {return_value, {^tprof_type, traces}} =
+        :tprof.profile(fun, %{
+          set_on_spawn: set_on_spawn,
+          pattern: matching,
+          type: tprof_type,
+          report: :return
+        })
+
+      inspected = :tprof.inspect({tprof_type, traces}, :process, sort_by)
+
+      :tprof.stop()
+
+      results =
+        inspected
+        |> Enum.map(fn {pid, {^tprof_type, measurement_total, call_results}} ->
+          parsed_calls =
+            call_results
+            |> filter_results(type, opts)
+            |> add_totals(measurement_total)
+
+          {pid, parsed_calls}
+        end)
+
+      {type, return_value, results}
+    end
+  else
+    defp profile_and_analyse(_fun, _opts) do
+      Mix.raise("mix profile.tprof requires Erlang/OTP27 or above")
+    end
   end
 
   defp to_tprof_type(:calls), do: :call_count

lib/mix/test/mix/tasks/profile.tprof_test.exs

@@ -6,6 +6,7 @@ defmodule Mix.Tasks.Profile.TprofTest do
   import ExUnit.CaptureIO
   alias Mix.Tasks.Profile.Tprof
 
+  # TODO remove once we require Erlang/OTP 27+
   @moduletag skip: System.otp_release() < "27"
 
   @expr "Enum.each(1..5, &String.Chars.Integer.to_string/1)"