Skip to content

Commit dee2101

Browse files
committed
A better variant of the same code, for my taste
1 parent c3459bd commit dee2101

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/shared/utils/challenge-listing/filter.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,15 @@ function filterByText(challenge, state) {
136136

137137
function filterByTrack(challenge, state) {
138138
if (!state.tracks) return true;
139-
let flag;
140-
// include code challenges with 'data science' tag in datasci track
141-
if (_.get(state.tracks, 'datasci')) {
142-
flag = _.includes(challenge.technologies, 'Data Science');
139+
140+
/* Development challenges having Data Science tech tag, still should be
141+
* included into data science track. */
142+
if (state.tracks[COMPETITION_TRACKS.DATA_SCIENCE]
143+
&& _.includes(challenge.technologies, 'Data Science')) {
144+
return true;
143145
}
144-
return flag || _.keys(state.tracks).some(track => challenge.communities.has(track));
146+
147+
return _.keys(state.tracks).some(track => challenge.communities.has(track));
145148
}
146149

147150
function filterByUpcoming(challenge, state) {

0 commit comments

Comments
 (0)