Skip to content

Missing support for {dynamic_type} property mapping #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swallez opened this issue Mar 22, 2022 · 2 comments · Fixed by #1723
Open

Missing support for {dynamic_type} property mapping #1558

swallez opened this issue Mar 22, 2022 · 2 comments · Fixed by #1723
Assignees
@swallez
Labels
backport 7.17 backport 8.1 lang:java Affects/found in the Java client specification wrong type

Comments

@swallez
Copy link
Member

swallez commented Mar 22, 2022

Found in elastic/elasticsearch-java#142

Index mapping dynamic templates provide more control on dynamic field mappings. Using them allows using the {dynamic_type} property type that is missing in the API spec.

This requires a new DynamicTypeProperty class with a type: '{dynamic_type}' variant tag.

Dynamic properties can be of type object, string, long, double, boolean, date and binary (see ES code). So DynamicTypeProperty must aggregate the properties of all these types.
@swallez swallez mentioned this issue Mar 22, 2022
Closed
@swallez swallez self-assigned this May 20, 2022
@swallez swallez mentioned this issue May 23, 2022
Merged
@nickyhuyskens
Copy link

hello @swallez
I see this ticket has been closed so I assume this should be fixed? Though I can't find DynamicType in the java api version 7.17.7 or 8.5.2.
Any idea what I'm doing wrong?
Kind regards
Nicky

@swallez
Copy link
Member Author

swallez commented Jan 24, 2023

Reopening. In PR #1723 we erroneously tagged DynamicProperty using {dynamic_property} instead of {dynamic_type}.

@swallez swallez reopened this Jan 24, 2023
@swallez swallez mentioned this issue Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swallez swallez

Labels
backport 7.17 backport 8.1 lang:java Affects/found in the Java client specification wrong type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spec issues reported in the Java client elastic/elasticsearch-specification
2 participants
@swallez @nickyhuyskens