Skip to content

Commit dde536f

Browse files
Remove name from PropertyBase (#1710) (#1711)
Co-authored-by: Steve Gordon <[email protected]>
1 parent c2407cc commit dde536f

File tree

4 files changed

+15
-22
lines changed

4 files changed

+15
-22
lines changed

output/schema/schema.json

Lines changed: 9 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/_types/mapping/Property.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ export class PropertyBase {
4343
local_metadata?: Metadata
4444
/** @doc_id mapping-meta-field */
4545
meta?: Dictionary<string, string>
46-
name?: PropertyName
4746
properties?: Dictionary<PropertyName, Property>
4847
ignore_above?: integer
4948
dynamic?: DynamicMapping

specification/_types/mapping/core.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,12 @@ export class SearchAsYouTypeProperty extends CorePropertyBase {
240240
type: 'search_as_you_type'
241241
}
242242

243+
// MatchOnlyTextProperty is an example of a property which does not derive from PropertyBase.
244+
// We have checked and this property does not support all properties of the base type.
245+
// In a future iteration we may remodel properties and identify truely common properties that should form
246+
// a base type that can be considered a common ancestor for all properties. Some clients will generate
247+
// a synthetic version of this today.
248+
243249
/**
244250
* A variant of text that trades scoring and efficiency of positional queries for space efficiency. This field
245251
* effectively stores data the same way as a text field that only indexes documents (index_options: docs) and

0 commit comments

Comments
 (0)