Allow quoted strings in comma-separated jstags (#1586) (#1587)

Co-authored-by: Sylvain Wallez <[email protected]>

Author: github-actions[bot]

compiler/src/model/utils.ts

@@ -595,7 +595,7 @@ export function hoistRequestAnnotations (
         'maintenance', 'manage', 'manage_follow_index', 'manage_ilm', 'manage_leader_index', 'monitor',
         'read', 'read_cross_cluster', 'view_index_metadata', 'write'
       ]
-      const values = value.split(',').map(v => v.trim())
+      const values = parseCommaSeparated(value)
       for (const v of values) {
         assert(jsDocs, privileges.includes(v), `The index privilege '${v}' does not exists.`)
       }
@@ -610,7 +610,7 @@ export function hoistRequestAnnotations (
         'manage_watcher', 'monitor', 'monitor_ml', 'monitor_rollup', 'monitor_snapshot', 'monitor_text_structure',
         'monitor_transform', 'monitor_watcher', 'read_ccr', 'read_ilm', 'read_pipeline', 'read_slm', 'transport_client'
       ]
-      const values = value.split(',').map(v => v.trim())
+      const values = parseCommaSeparated(value)
       for (const v of values) {
         assert(jsDocs, privileges.includes(v), `The cluster privilege '${v}' does not exists.`)
       }
@@ -657,7 +657,7 @@ export function hoistTypeAnnotations (type: model.TypeDefinition, jsDocs: JSDoc[
       assert(jsDocs, value.trim() !== '', `Type ${type.name.namespace}.${type.name.name}'s @doc_id cannot be empty`)
       type.docId = value.trim()
     } else if (tag === 'codegen_names') {
-      type.codegenNames = value.split(',').map(v => v.trim())
+      type.codegenNames = parseCommaSeparated(value)
       assert(jsDocs,
         type.kind === 'type_alias' && type.type.kind === 'union_of' && type.type.items.length === type.codegenNames.length,
         '@codegen_names must have the number of items as the union definition'
@@ -685,7 +685,7 @@ function hoistPropertyAnnotations (property: model.Property, jsDocs: JSDoc[]): v
   setTags(jsDocs, property, tags, validTags, (tags, tag, value) => {
     if (tag.endsWith('_serializer')) {
     } else if (tag === 'aliases') {
-      property.aliases = value.split(',').map(v => v.trim())
+      property.aliases = parseCommaSeparated(value)
     } else if (tag === 'codegen_name') {
       property.codegenName = value
     } else if (tag === 'doc_url') {
@@ -778,7 +778,7 @@ function hoistEnumMemberAnnotations (member: model.EnumMember, jsDocs: JSDoc[]):
     if (tag === 'codegen_name') {
       member.codegenName = value
     } else if (tag === 'aliases') {
-      member.aliases = value.split(',').map(v => v.trim())
+      member.aliases = parseCommaSeparated(value)
     } else if (tag === 'since') {
       assert(jsDocs, semver.valid(value), `${member.name}'s @since is not valid semver: ${value}`)
       member.since = value
@@ -962,6 +962,14 @@ export function parseVariantNameTag (jsDoc: JSDoc[]): string | undefined {
   return name.replace(/'/g, '')
 }
 
+/**
+ * Parses a list of comma-separated values as an array. Values can optionally be enclosed with single
+ * or double quotes.
+ */
+export function parseCommaSeparated (value: string): string[] {
+  return value.split(',').map(v => v.trim().replace(/["']/g, ''))
+}
+
 /**
  * Given a declaration, returns true if the declaration
  * if defined but never used, false otherwise.