Skip to content

Commit 791a76c

Browse files
stevejgordonAnaethelion
authored andcommitted
Make index settings blocks stringified (#2111)
* Make index settings blocks stringified * Update stack version in build validation step --------- Co-authored-by: Laurent Saint-Félix <[email protected]>
1 parent e04fd96 commit 791a76c

File tree

4 files changed

+48
-24
lines changed

4 files changed

+48
-24
lines changed

.github/workflows/validate-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
if: github.repository_owner == 'elastic' # this action will fail if executed from a fork
1919
runs-on: ubuntu-latest
2020
env:
21-
STACK_VERSION: 8.6-SNAPSHOT
21+
STACK_VERSION: 8.9-SNAPSHOT
2222

2323
steps:
2424
- uses: actions/checkout@v2

output/schema/schema.json

Lines changed: 39 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/indices/_types/IndexSettings.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,10 @@ export class SettingsQueryString {
243243
}
244244

245245
export class IndexSettingBlocks {
246-
read_only?: boolean
247-
read_only_allow_delete?: boolean
248-
read?: boolean
249-
write?: boolean | string // TODO: should be bool only
246+
read_only?: Stringified<boolean>
247+
read_only_allow_delete?: Stringified<boolean>
248+
read?: Stringified<boolean>
249+
write?: Stringified<boolean>
250250
metadata?: Stringified<boolean>
251251
}
252252

0 commit comments

Comments
 (0)