Skip to content

Commit 59a96d5

Browse files
authored
[Backport 7.17] Remove Name from PropertyBase (#1712)
* Remove name from PropertyBase (#1710) * Re-run make contrib
1 parent 02fe66b commit 59a96d5

File tree

4 files changed

+15
-22
lines changed

4 files changed

+15
-22
lines changed

output/schema/schema.json

Lines changed: 9 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/_types/mapping/Property.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import {
4242
export class PropertyBase {
4343
local_metadata?: Metadata
4444
meta?: Dictionary<string, string>
45-
name?: PropertyName
4645
properties?: Dictionary<PropertyName, Property>
4746
ignore_above?: integer
4847
dynamic?: DynamicMapping

specification/_types/mapping/core.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,12 @@ export class SearchAsYouTypeProperty extends CorePropertyBase {
236236
type: 'search_as_you_type'
237237
}
238238

239+
// MatchOnlyTextProperty is an example of a property which does not derive from PropertyBase.
240+
// We have checked and this property does not support all properties of the base type.
241+
// In a future iteration we may remodel properties and identify truely common properties that should form
242+
// a base type that can be considered a common ancestor for all properties. Some clients will generate
243+
// a synthetic version of this today.
244+
239245
/**
240246
* A variant of text that trades scoring and efficiency of positional queries for space efficiency. This field
241247
* effectively stores data the same way as a text field that only indexes documents (index_options: docs) and

0 commit comments

Comments
 (0)