Skip to content

Commit d8dd3b9

Browse files
authored
Type check against opentelemetry-api (#92)
1 parent f5dd27a commit d8dd3b9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

elasticsearch_serverless/_otel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def helpers_span(self, span_name: str) -> Generator[OpenTelemetrySpan, None, Non
106106

107107
@contextlib.contextmanager
108108
def use_span(self, span: OpenTelemetrySpan) -> Generator[None, None, None]:
109-
if not self.enabled or self.tracer is None:
109+
if not self.enabled or self.tracer is None or span.otel_span is None:
110110
yield
111111
return
112112

noxfile.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,16 @@ def format(session):
7878

7979
@nox.session()
8080
def lint(session):
81-
session.install("flake8", "black~=24.0", "mypy", "isort", "types-requests")
81+
session.install(
82+
"flake8", "black~=24.0", "mypy", "isort", "types-requests", "opentelemetry-api"
83+
)
8284

8385
session.run("isort", "--check", "--profile=black", *SOURCE_FILES)
8486
session.run("black", "--check", *SOURCE_FILES)
8587
session.run("flake8", *SOURCE_FILES)
8688
session.run("python", "utils/license-headers.py", "check", *SOURCE_FILES)
8789

88-
session.install(".[async,requests,orjson,pyarrow]", env=INSTALL_ENV)
90+
session.install(".[dev]", env=INSTALL_ENV)
8991

9092
# Run mypy on the package and then the type examples separately for
9193
# the two different mypy use-cases, ourselves and our users.

0 commit comments

Comments
 (0)