Skip to content

Commit 0995c1f

Browse files
fix flaky integration test (#2775) (#2786)
(cherry picked from commit 8aee949) Co-authored-by: Miguel Grinberg <[email protected]>
1 parent 5f3f772 commit 0995c1f

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

test_elasticsearch/test_dsl/test_integration/test_examples/_async/test_vectors.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import pytest
2323

2424
from elasticsearch import AsyncElasticsearch
25-
from test_elasticsearch.test_dsl.async_sleep import sleep
2625

2726
from ..async_examples import vectors
2827

@@ -48,9 +47,6 @@ def encode(self, text: str) -> List[float]:
4847
mocker.patch.object(vectors, "SentenceTransformer", new=MockModel)
4948

5049
await vectors.create()
51-
for i in range(10):
52-
results = await (await vectors.search("Welcome to our team!")).execute()
53-
if len(results.hits) > 0:
54-
break
55-
await sleep(0.1)
50+
await vectors.WorkplaceDoc._index.refresh()
51+
results = await (await vectors.search("Welcome to our team!")).execute()
5652
assert results[0].name == "New Employee Onboarding Guide"

test_elasticsearch/test_dsl/test_integration/test_examples/_sync/test_vectors.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import pytest
2323

2424
from elasticsearch import Elasticsearch
25-
from test_elasticsearch.test_dsl.sleep import sleep
2625

2726
from ..examples import vectors
2827

@@ -48,9 +47,6 @@ def encode(self, text: str) -> List[float]:
4847
mocker.patch.object(vectors, "SentenceTransformer", new=MockModel)
4948

5049
vectors.create()
51-
for i in range(10):
52-
results = (vectors.search("Welcome to our team!")).execute()
53-
if len(results.hits) > 0:
54-
break
55-
sleep(0.1)
50+
vectors.WorkplaceDoc._index.refresh()
51+
results = (vectors.search("Welcome to our team!")).execute()
5652
assert results[0].name == "New Employee Onboarding Guide"

0 commit comments

Comments
 (0)