-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Pre-flight product check #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-flight product check #5728
Conversation
CI build is unrelated and fixed in #5729 |
These no longer work using a custom path as the product check fails with a 404 and is assumed invalid.
2685ea5
to
159363f
Compare
This is a breaking change, not an enhancement. After upgrading from NuGet "NEST 7.13.2" to "NEST 7.14.0" I get the following error: Associated code:
ES instance = v.7.9.2. Note : I use the official ES Ingest Attachment Processor Plugin. |
We have the same problem when updating Elasticsearch.Net to 7.14.0 and NEST to 7.14.0 |
@glautrou With the We have labelled this as an enhancement since it affects only unsupported client and server combinations. In supported configurations, the change is not breaking. The intent here is to make this incompatibility explicit by failing fast to avoid consumers incorrectly assuming they are running in a supported configuration which is not tested and may not function as expected. @jbrouwer1 The Elasticsearch clients go through rigorous testing and validation against the official Elasticsearch distribution coming from Elastic. Since the AWS Elasticsearch Service has incompatible APIs with Elasticsearch itself, either by missing APIs or has incompatible format, we do not support it. Please consider using Elastic Cloud for an official and formally supported hosted Elasticsearch distribution. |
Adds support for running a pre-flight check on first use to check the product and version.
This check is part of the request pipeline and runs once, before any other requests to check the validity of the product, issuing appropriate warnings and errors when failures are detected.