Skip to content

BulkUpdateOperation.RetryOnConflict is boolean not a number #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eragra3 opened this issue Jul 18, 2023 · 1 comment · Fixed by #7841
Closed

BulkUpdateOperation.RetryOnConflict is boolean not a number #7838

Eragra3 opened this issue Jul 18, 2023 · 1 comment · Fixed by #7841
Labels
8.x Relates to a 8.x client version

Comments

@Eragra3
Copy link

Eragra3 commented Jul 18, 2023

Elastic.Clients.Elasticsearch version:
8.1.2

Elasticsearch version:
8.8.1

Hello, this may be more of a question than issue, but when we use BulkUpdateOperation, its property RetryOnConflict is of bool type, not a numeric.
When the query is sent to Elasticsearch it fails with:

Current token (VALUE_TRUE) not numeric, can not use numeric value accessors

I think retry_on_conflict used to be numeric on previous versions and ES documentation mentiones it as a numeric:
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update.html#docs-update-api-query-params
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html#bulk-update

@Eragra3 Eragra3 added the 8.x Relates to a 8.x client version label Jul 18, 2023
@flobernd flobernd added the bug label Jul 18, 2023
@flobernd
Copy link
Member

Hi @Eragra3, thanks for reporting!

RetryOnConflict is typed as integer in the specification, but a bool in the C# codebase (the BulkUpdateOperation is not auto-generated at the moment).

I try to include a fix for this in the upcoming 8.9.0 release. For now you could probably use a null value for this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants