Skip to content

[FEATURE] Support update index settings API #7703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SandervWickeren opened this issue May 5, 2023 · 6 comments
Open

[FEATURE] Support update index settings API #7703

SandervWickeren opened this issue May 5, 2023 · 6 comments
Labels
8.x Relates to a 8.x client version Category: Feature State: Blocked

Comments

@SandervWickeren
Copy link

Elastic.Clients.Elasticsearch version: 8.1.0

Elasticsearch version: 8.7.x

.NET runtime version: .Net7

Operating system version: not applicable

Description of the problem including expected versus actual behavior:
As mentioned in Tune Index for Speed, you should update the index settings before and after indexing if you want to tune for speed. We are in a process of upgrading our Elastic setup from Nest to ElasticsearchClient and it seems like the update index settings api isn't supported yet.

Any chance this can be added in a next release?

Steps to reproduce:

  1. There is no implementation of UpdateSettingsAsync, while it does exists for Nest.

Expected behavior
Support added

@SandervWickeren SandervWickeren added the 8.x Relates to a 8.x client version label May 5, 2023
@stevejgordon
Copy link
Contributor

Thanks for raising this, @SandervWickeren. Index settings are a little complex since we must explicitly distinguish between null and unset values, which have specific meanings. We are in the process of updating the specification to represent these such that code generators can produce proper representations of explicitly nullable properties. I think we need that work to land before we can introduce this endpoint.

@SandervWickeren
Copy link
Author

@stevejgordon thanks for the quick reply! In that case, I'll continue to use the NEST client alongside the new ElasticsearchClient for now, and port as soon as this feature is released.

@TheFireCookie
Copy link
Contributor

Hello, this is blocking for us too. Any plan to advance on that?

@flobernd
Copy link
Member

flobernd commented Jul 12, 2023

Hi @TheFireCookie! The progress can be tracked in issue that was mentioned by Steve:
elastic/elasticsearch-specification#2049

As you can see, there is some stuff going on, but unfortunately not all prerequisites are done yet.

@apr-un
Copy link

apr-un commented May 28, 2024

Hi, fyi: @SandervWickeren , @TheFireCookie this functionality is implemented and I can confirm it works correctly thanks to @flobernd :)
See example code at #8204

@flobernd
Copy link
Member

There is still a small part missing. The "unset" aka semantic null functionality is not implemented yet. I plan to ship this feature soon, but most of the Index Settings API is already functional 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version Category: Feature State: Blocked
Projects
None yet
Development

No branches or pull requests

5 participants