Skip to content

[FEATURE] Add client overloads accepting descriptors #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
b93rn opened this issue Mar 24, 2023 · 3 comments · Fixed by #7541
Closed

[FEATURE] Add client overloads accepting descriptors #7475

b93rn opened this issue Mar 24, 2023 · 3 comments · Fixed by #7541
Labels
8.x Relates to a 8.x client version
Milestone

Comments

@b93rn
Copy link

b93rn commented Mar 24, 2023

Elastic.Clients.Elasticsearch version:
8.08

Why do i need an Action<SearchRequestDescriptor> like shown below?

public virtual Task<SearchResponse> SearchAsync(Action<SearchRequestDescriptor> configureRequest, CancellationToken cancellationToken = default);

Request:
Add overload <SearchRequestDescriptor as the NEST client had.

@b93rn b93rn added the 8.x Relates to a 8.x client version label Mar 24, 2023
@stevejgordon stevejgordon added this to the 8.1.0 milestone Mar 24, 2023
@stevejgordon
Copy link
Contributor

Thanks for raising this, @b93rn. This is a gap we should close. I'll look to amend this in our code generation so that the extra overloads are included.

@stevejgordon stevejgordon changed the title Missing SearchAsync overload [FEATURE] Missing SearchAsync overload Mar 24, 2023
@stevejgordon stevejgordon changed the title [FEATURE] Missing SearchAsync overload [FEATURE] Add client overloads accepting descriptors Mar 24, 2023
@b93rn b93rn closed this as completed Mar 24, 2023
@b93rn b93rn reopened this Mar 24, 2023
@svenhartmann
Copy link

I also missed this but the migration from a NEST SearchDescriptor to a 8.x SearchRequest with Object initializer syntax can be done in a short amount of time.

Maybe this helps you to get your work done without having the feature yet.

@b93rn
Copy link
Author

b93rn commented Mar 27, 2023

I also missed this but the migration from a NEST SearchDescriptor to a 8.x SearchRequest with Object initializer syntax can be done in a short amount of time.

Maybe this helps you to get your work done without having the feature yet.

This comment might push me in the right direction. My thoughts were that SearchReqeustDescriptor is the equivalent of SearchDescriptor in NEST?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants