Correct serialized property name on AsciiFoldingTokenFilter (#2893)

Closes #2892

Author: russcam

src/Nest/Analysis/Analyzers/AnalyzerBase.cs

@@ -16,10 +16,7 @@ public abstract class AnalyzerBase : IAnalyzer
 	{
 		internal AnalyzerBase() { }
 
-		protected AnalyzerBase(string type)
-		{
-			Type = type;
-		}
+		protected AnalyzerBase(string type) => Type = type;
 
 		public string Version { get; set; }
 

src/Nest/Analysis/Normalizers/NormalizerBase.cs

@@ -16,10 +16,7 @@ public abstract class NormalizerBase : INormalizer
 	{
 		internal NormalizerBase() { }
 
-		protected NormalizerBase(string type)
-		{
-			Type = type;
-		}
+		protected NormalizerBase(string type) => Type = type;
 
 		public string Version { get; set; }
 

src/Nest/Analysis/TokenFilters/AsciiFoldingTokenFilter.cs

@@ -1,25 +1,28 @@
-namespace Nest
+using Newtonsoft.Json;
+
+namespace Nest
 {
 
 	/// <summary>
-	/// A token filter of type asciifolding that converts alphabetic, numeric, and symbolic Unicode characters which are 
+	/// A token filter of type asciifolding that converts alphabetic, numeric, and symbolic Unicode characters which are
 	/// <para> not in the first 127 ASCII characters (the “Basic Latin” Unicode block) into their ASCII equivalents, if one exists.</para>
 	/// </summary>
 	public interface IAsciiFoldingTokenFilter : ITokenFilter
 	{
+		[JsonProperty("preserve_original")]
 		bool? PreserveOriginal { get; set; }
 	}
 
 	///<inheritdoc/>
 	public class AsciiFoldingTokenFilter : TokenFilterBase, IAsciiFoldingTokenFilter
 	{
-		public AsciiFoldingTokenFilter() : base("asciifolding") { } 
+		public AsciiFoldingTokenFilter() : base("asciifolding") { }
 
 		public bool? PreserveOriginal { get; set; }
 	}
 
 	///<inheritdoc/>
-	public class AsciiFoldingTokenFilterDescriptor 
+	public class AsciiFoldingTokenFilterDescriptor
 		: TokenFilterDescriptorBase<AsciiFoldingTokenFilterDescriptor, IAsciiFoldingTokenFilter>, IAsciiFoldingTokenFilter
 	{
 		protected override string Type => "asciifolding";
@@ -30,4 +33,4 @@ public class AsciiFoldingTokenFilterDescriptor
 		public AsciiFoldingTokenFilterDescriptor PreserveOriginal(bool? preserve = true) => Assign(a => a.PreserveOriginal = preserve);
 	}
 
-}
+}

src/Tests/Analysis/TokenFilters/TokenFilterUsageTests.cs

@@ -18,7 +18,7 @@ public class TokenFilterUsageTests : PromiseUsageTestBase<IIndexSettings, IndexS
 					myAscii = new
 					{
 						type = "asciifolding",
-						preserveOriginal = true
+						preserve_original = true
 					},
 					myCommonGrams = new
 					{

src/Tests/CodeStandards/Analysis.cs

@@ -0,0 +1,61 @@
+using System;
+using System.Linq;
+using System.Reflection;
+using FluentAssertions;
+using Nest;
+using Newtonsoft.Json;
+using Tests.Framework;
+
+namespace Tests.CodeStandards
+{
+	public class Analysis
+	{
+		/**
+		* Every analyzer interface should attribute properties with JsonPropertyAttribute
+		*/
+		[U]
+		public void AnalyzerPropertiesAreAttributedWithJsonPropertyAttribute() =>
+			PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(typeof(IAnalyzer));
+
+		/**
+		* Every normalizer interface should attribute properties with JsonPropertyAttribute
+		*/
+		[U]
+		public void NormalizerPropertiesAreAttributedWithJsonPropertyAttribute() =>
+			PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(typeof(INormalizer));
+
+		/**
+		* Every char filter interface should attribute properties with JsonPropertyAttribute
+		*/
+		[U]
+		public void CharFilterPropertiesAreAttributedWithJsonPropertyAttribute() =>
+			PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(typeof(ICharFilter));
+
+		/**
+		* Every tokenizer interface should attribute properties with JsonPropertyAttribute
+		*/
+		[U]
+		public void TokenizerPropertiesAreAttributedWithJsonPropertyAttribute() =>
+			PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(typeof(ITokenizer));
+
+		/**
+		* Every token filter interface should attribute properties with JsonPropertyAttribute
+		*/
+		[U]
+		public void TokenFilterPropertiesAreAttributedWithJsonPropertyAttribute() =>
+			PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(typeof(ITokenFilter));
+
+		private static void PropertiesOfTypeAreAttributedWithJsonPropertyAttribute(Type type)
+		{
+			var types =
+				from t in type.Assembly().Types()
+				where t.IsInterface() && type.IsAssignableFrom(t)
+				let properties = t.GetProperties()
+				from p in properties
+				where p.GetCustomAttribute(typeof(JsonPropertyAttribute)) == null
+				select $"{p.Name} on {t.Name} does not have {nameof(JsonPropertyAttribute)} applied";
+
+			types.Should().BeEmpty();
+		}
+	}
+}