Change RequireFieldMatch to bool? with default value

Author: russcam

docs/search/request/highlighting-usage.asciidoc

@@ -35,6 +35,7 @@ s => s
 .Highlight(h => h
     .PreTags("<tag1>")
     .PostTags("</tag1>")
+    .Encoder(HighlighterEncoder.Html)
     .Fields(
         fs => fs
             .Field(p => p.Name.Suffix("standard"))
@@ -50,6 +51,7 @@ s => s
             .PreTags("<name>")
             .PostTags("</name>")
             .BoundaryMaxScan(50)
+            .PhraseLimit(10)
             .HighlightQuery(q => q
                 .Match(m => m
                     .Field(p => p.LeadDeveloper.FirstName)
@@ -87,6 +89,7 @@ new SearchRequest<Project>
     {
         PreTags = new[] { "<tag1>" },
         PostTags = new[] { "</tag1>" },
+        Encoder = HighlighterEncoder.Html,
         Fields = new Dictionary<Field, IHighlightField>
         {
             { "name.standard", new HighlightField
@@ -102,6 +105,7 @@ new SearchRequest<Project>
             { "leadDeveloper.firstName", new HighlightField
                 {
                     Type = "fvh",
+                    PhraseLimit = 10,
                     BoundaryMaxScan = 50,
                     PreTags = new[] { "<name>"},
                     PostTags = new[] { "</name>"},
@@ -147,6 +151,7 @@ new SearchRequest<Project>
     "post_tags": [
       "</tag1>"
     ],
+    "encoder": "html",
     "fields": {
       "name.standard": {
         "type": "plain",
@@ -158,6 +163,7 @@ new SearchRequest<Project>
       },
       "leadDeveloper.firstName": {
         "type": "fvh",
+        "phrase_limit": 10,
         "boundary_max_scan": 50,
         "pre_tags": [
           "<name>"

src/Nest/Search/Search/Highlighting/Highlight.cs

@@ -221,13 +221,13 @@ public HighlightDescriptor<T> Fields(params Func<HighlightFieldDescriptor<T>, IH
 		public HighlightDescriptor<T> PostTags(IEnumerable<string> postTags) => Assign(a => a.PostTags = postTags.ToListOrNullIfEmpty());
 
 		// <inheritdoc/>
-		public HighlightDescriptor<T> FragmentSize(int fragmentSize) => Assign(a => a.FragmentSize = fragmentSize);
+		public HighlightDescriptor<T> FragmentSize(int? fragmentSize) => Assign(a => a.FragmentSize = fragmentSize);
 
 		// <inheritdoc/>
-		public HighlightDescriptor<T> NumberOfFragments(int numberOfFragments) => Assign(a => a.NumberOfFragments = numberOfFragments);
+		public HighlightDescriptor<T> NumberOfFragments(int? numberOfFragments) => Assign(a => a.NumberOfFragments = numberOfFragments);
 
 		// <inheritdoc/>
-		public HighlightDescriptor<T> FragmentOffset(int fragmentOffset) => Assign(a => a.FragmentOffset = fragmentOffset);
+		public HighlightDescriptor<T> FragmentOffset(int? fragmentOffset) => Assign(a => a.FragmentOffset = fragmentOffset);
 
 		// <inheritdoc/>
 		public HighlightDescriptor<T> Encoder(HighlighterEncoder? encoder) => Assign(a => a.Encoder = encoder);
@@ -236,13 +236,13 @@ public HighlightDescriptor<T> Fields(params Func<HighlightFieldDescriptor<T>, IH
 		public HighlightDescriptor<T> Order(HighlighterOrder? order) => Assign(a => a.Order = order);
 
 		// <inheritdoc/>
-		public HighlightDescriptor<T> RequireFieldMatch(bool requireFieldMatch = true) => Assign(a => a.RequireFieldMatch = requireFieldMatch);
+		public HighlightDescriptor<T> RequireFieldMatch(bool? requireFieldMatch = true) => Assign(a => a.RequireFieldMatch = requireFieldMatch);
 
 		// <inheritdoc/>
 		public HighlightDescriptor<T> BoundaryCharacters(string boundaryCharacters) => Assign(a => a.BoundaryChars = boundaryCharacters);
 
 		// <inheritdoc/>
-		public HighlightDescriptor<T> BoundaryMaxScan(int boundaryMaxScan) => Assign(a => a.BoundaryMaxScan = boundaryMaxScan);
+		public HighlightDescriptor<T> BoundaryMaxScan(int? boundaryMaxScan) => Assign(a => a.BoundaryMaxScan = boundaryMaxScan);
 
 		// <inheritdoc/>
 		public HighlightDescriptor<T> MaxFragmentLength(int? maxFragmentLength) => Assign(a => a.MaxFragmentLength = maxFragmentLength);

src/Nest/Search/Search/Highlighting/HighlighterTagsSchema.cs

@@ -14,11 +14,11 @@ public enum HighlighterTagsSchema
 		/// Use a specific "tag" schemas.
 		/// </summary>
 		/// <remarks>
-		/// Currently a single schema called "styled" with the following pre_tags:
-		/// &lt;em class="hlt1"&gt;, &lt;em class="hlt2"&gt;, &lt;em class="hlt3"&gt;,
-		/// &lt;em class="hlt4"&gt;, &lt;em class="hlt5"&gt;, &lt;em class="hlt6"&gt;,
-		/// &lt;em class="hlt7"&gt;, &lt;em class="hlt8"&gt;, &lt;em class="hlt9"&gt;,
-		/// &lt;em class="hlt10"&gt;
+		/// <para>Currently a single schema called "styled" with the following pre_tags:</para>
+		/// <para>&lt;em class="hlt1"&gt;, &lt;em class="hlt2"&gt;, &lt;em class="hlt3"&gt;,</para>
+		/// <para>&lt;em class="hlt4"&gt;, &lt;em class="hlt5"&gt;, &lt;em class="hlt6"&gt;,</para>
+		/// <para>&lt;em class="hlt7"&gt;, &lt;em class="hlt8"&gt;, &lt;em class="hlt9"&gt;,</para>
+		/// <para>&lt;em class="hlt10"&gt;</para>
 		/// </remarks>
 		[EnumMember(Value = "styled")]
 		Styled