Skip to content

Commit 9759c5a

Browse files
github-actions[bot]stevejgordon
github-actions[bot]
and
stevejgordon
authored
Fix to ensure dynamic HTTP methods are used when available (#7058) (#7060)
Co-authored-by: Steve Gordon <[email protected]>
1 parent a737194 commit 9759c5a

File tree

116 files changed

+342
-279
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

116 files changed

+342
-279
lines changed

‎src/Elastic.Clients.Elasticsearch/Api/IndexRequest.cs

-3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ public partial class IndexRequest<TDocument> : ICustomJsonWriter
1414
{
1515
public IndexRequest() : this(typeof(TDocument)) { }
1616

17-
//public IndexRequest(TDocument document) : this(typeof(TDocument)) => Document = document;
18-
1917
public IndexRequest(TDocument document, Id id) : this(typeof(TDocument), id) => Document = document;
2018

2119
protected override HttpMethod? DynamicHttpMethod => GetHttpMethod(this);
@@ -34,7 +32,6 @@ internal static HttpMethod GetHttpMethod(IndexRequest<TDocument> request) =>
3432

3533
public sealed partial class IndexRequestDescriptor<TDocument> : ICustomJsonWriter
3634
{
37-
// TODO: Codegen
3835
public IndexRequestDescriptor<TDocument> Document(TDocument document)
3936
{
4037
DocumentValue = document;

‎src/Elastic.Clients.Elasticsearch/Core/Fluent/Descriptor.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace Elastic.Clients.Elasticsearch.Fluent;
1414

1515
public abstract class Descriptor
1616
{
17-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
17+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
1818
// We don't expect consumers to derive from this public base class.
1919
internal Descriptor() { }
2020

@@ -49,7 +49,7 @@ public abstract class Descriptor<TDescriptor> : Descriptor
4949
{
5050
private readonly TDescriptor _self;
5151

52-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
52+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
5353
// We don't expect consumers to derive from this public base class.
5454
internal Descriptor() : base() => _self = (TDescriptor)this;
5555

@@ -64,7 +64,7 @@ public abstract class Descriptor<TDescriptor> : Descriptor
6464
public abstract class SerializableDescriptor<TDescriptor> : Descriptor<TDescriptor>, ISelfSerializable
6565
where TDescriptor : SerializableDescriptor<TDescriptor>
6666
{
67-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
67+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
6868
// We don't expect consumers to derive from this public base class.
6969
internal SerializableDescriptor(): base() { }
7070

‎src/Elastic.Clients.Elasticsearch/Core/Fluent/Promise/IsADictionaryDescriptor.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public abstract class IsADictionaryDescriptor<TDescriptor, TPromised, TKey, TVal
1111
where TDescriptor : IsADictionaryDescriptor<TDescriptor, TPromised, TKey, TValue>
1212
where TPromised : class, IIsADictionary<TKey, TValue>
1313
{
14-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
14+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
1515
// We don't expect consumers to derive from this public base class.
1616
internal IsADictionaryDescriptor(TPromised instance) : base(instance) { }
1717

‎src/Elastic.Clients.Elasticsearch/Core/Fluent/Promise/PromiseDescriptor.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public abstract class PromiseDescriptor<TDescriptor, TValue> : Descriptor, IProm
1212
{
1313
internal readonly TValue PromisedValue;
1414

15-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
15+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
1616
// We don't expect consumers to derive from this public base class.
1717
internal PromiseDescriptor(TValue instance) : base()
1818
{

‎src/Elastic.Clients.Elasticsearch/Core/Request/PlainRequest.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace Elastic.Clients.Elasticsearch.Requests;
1111
public abstract class PlainRequest<TParameters> : Request<TParameters>
1212
where TParameters : RequestParameters, new()
1313
{
14-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
14+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
1515
// We don't expect consumers to derive from this public base class.
1616
internal PlainRequest() { }
1717

‎src/Elastic.Clients.Elasticsearch/Core/Request/Request.cs

+29-7
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,43 @@
88

99
namespace Elastic.Clients.Elasticsearch.Requests;
1010

11+
/// <summary>
12+
/// Base type for requests sent by the client.
13+
/// </summary>
1114
public abstract class Request
1215
{
16+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
17+
// We don't expect consumers to derive from this public base class.
1318
internal Request() { }
1419

1520
internal virtual string? Accept { get; } = null;
1621

1722
internal virtual string? ContentType { get; } = null;
1823

19-
[JsonIgnore] internal abstract HttpMethod HttpMethod { get; }
20-
21-
[JsonIgnore] internal abstract bool SupportsBody { get; }
22-
23-
[JsonIgnore] protected RouteValues RouteValues { get; } = new();
24-
25-
[JsonIgnore] protected virtual HttpMethod? DynamicHttpMethod => null;
24+
/// <summary>
25+
/// The default HTTP method for the request which is based on the Elasticsearch Specification endpoint definition.
26+
/// </summary>
27+
[JsonIgnore]
28+
protected abstract HttpMethod StaticHttpMethod { get; }
29+
30+
[JsonIgnore]
31+
internal abstract bool SupportsBody { get; }
32+
33+
[JsonIgnore]
34+
protected RouteValues RouteValues { get; } = new();
35+
36+
/// <summary>
37+
/// Allows for per request replacement of the specified HTTP method, including scenarios such as indexing which
38+
/// require access to the document to determine the correct URL path and method combination to choose.
39+
/// </summary>
40+
[JsonIgnore]
41+
protected virtual HttpMethod? DynamicHttpMethod => null;
42+
43+
/// <summary>
44+
/// The final HTTP method used to send the request to the Elasticsearch server.
45+
/// </summary>
46+
[JsonIgnore]
47+
internal HttpMethod HttpMethod => DynamicHttpMethod ?? StaticHttpMethod;
2648

2749
internal abstract ApiUrls ApiUrls { get; }
2850

‎src/Elastic.Clients.Elasticsearch/Core/Request/RequestDescriptor.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public abstract partial class RequestDescriptor<TDescriptor, TParameters> : Requ
2121

2222
void ISelfSerializable.Serialize(Utf8JsonWriter writer, JsonSerializerOptions options, IElasticsearchClientSettings settings) => Serialize(writer, options, settings);
2323

24-
// This internal ctor ensures that only types defined within the client assembly can derive from this base class.
24+
// This internal ctor ensures that only types defined within the Elastic.Clients.Elasticsearch assembly can derive from this base class.
2525
// We don't expect consumers to derive from this public base class.
2626
internal RequestDescriptor() => _descriptor = (TDescriptor)this;
2727

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/AsyncSearch/AsyncSearchStatusRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public AsyncSearchStatusRequest(Elastic.Clients.Elasticsearch.Id id) : base(r =>
3838
}
3939

4040
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchStatus;
41-
internal override HttpMethod HttpMethod => HttpMethod.GET;
41+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
4242
internal override bool SupportsBody => false;
4343
}
4444

@@ -54,7 +54,7 @@ internal AsyncSearchStatusRequestDescriptor()
5454
}
5555

5656
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchStatus;
57-
internal override HttpMethod HttpMethod => HttpMethod.GET;
57+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
5858
internal override bool SupportsBody => false;
5959
public AsyncSearchStatusRequestDescriptor<TDocument> Id(Elastic.Clients.Elasticsearch.Id id)
6060
{
@@ -79,7 +79,7 @@ internal AsyncSearchStatusRequestDescriptor()
7979
}
8080

8181
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchStatus;
82-
internal override HttpMethod HttpMethod => HttpMethod.GET;
82+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
8383
internal override bool SupportsBody => false;
8484
public AsyncSearchStatusRequestDescriptor Id(Elastic.Clients.Elasticsearch.Id id)
8585
{

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/AsyncSearch/DeleteAsyncSearchRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public DeleteAsyncSearchRequest(Elastic.Clients.Elasticsearch.Id id) : base(r =>
3838
}
3939

4040
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchDelete;
41-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
41+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
4242
internal override bool SupportsBody => false;
4343
}
4444

@@ -54,7 +54,7 @@ internal DeleteAsyncSearchRequestDescriptor()
5454
}
5555

5656
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchDelete;
57-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
57+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
5858
internal override bool SupportsBody => false;
5959
public DeleteAsyncSearchRequestDescriptor<TDocument> Id(Elastic.Clients.Elasticsearch.Id id)
6060
{
@@ -79,7 +79,7 @@ internal DeleteAsyncSearchRequestDescriptor()
7979
}
8080

8181
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchDelete;
82-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
82+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
8383
internal override bool SupportsBody => false;
8484
public DeleteAsyncSearchRequestDescriptor Id(Elastic.Clients.Elasticsearch.Id id)
8585
{

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/AsyncSearch/GetAsyncSearchRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public GetAsyncSearchRequest(Elastic.Clients.Elasticsearch.Id id) : base(r => r.
4646
}
4747

4848
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchGet;
49-
internal override HttpMethod HttpMethod => HttpMethod.GET;
49+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
5050
internal override bool SupportsBody => false;
5151
[JsonIgnore]
5252
public Elastic.Clients.Elasticsearch.Duration? KeepAlive { get => Q<Elastic.Clients.Elasticsearch.Duration?>("keep_alive"); set => Q("keep_alive", value); }
@@ -70,7 +70,7 @@ internal GetAsyncSearchRequestDescriptor()
7070
}
7171

7272
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchGet;
73-
internal override HttpMethod HttpMethod => HttpMethod.GET;
73+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
7474
internal override bool SupportsBody => false;
7575
public GetAsyncSearchRequestDescriptor<TDocument> KeepAlive(Elastic.Clients.Elasticsearch.Duration? keepAlive) => Qs("keep_alive", keepAlive);
7676
public GetAsyncSearchRequestDescriptor<TDocument> TypedKeys(bool? typedKeys = true) => Qs("typed_keys", typedKeys);
@@ -98,7 +98,7 @@ internal GetAsyncSearchRequestDescriptor()
9898
}
9999

100100
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchGet;
101-
internal override HttpMethod HttpMethod => HttpMethod.GET;
101+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
102102
internal override bool SupportsBody => false;
103103
public GetAsyncSearchRequestDescriptor KeepAlive(Elastic.Clients.Elasticsearch.Duration? keepAlive) => Qs("keep_alive", keepAlive);
104104
public GetAsyncSearchRequestDescriptor TypedKeys(bool? typedKeys = true) => Qs("typed_keys", typedKeys);

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/AsyncSearch/SubmitAsyncSearchRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ public SubmitAsyncSearchRequest(Elastic.Clients.Elasticsearch.Indices? indices)
546546
}
547547

548548
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchSubmit;
549-
internal override HttpMethod HttpMethod => HttpMethod.POST;
549+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
550550
internal override bool SupportsBody => true;
551551
[JsonIgnore]
552552
public Elastic.Clients.Elasticsearch.Duration? WaitForCompletionTimeout { get => Q<Elastic.Clients.Elasticsearch.Duration?>("wait_for_completion_timeout"); set => Q("wait_for_completion_timeout", value); }
@@ -782,7 +782,7 @@ public SubmitAsyncSearchRequestDescriptor()
782782
}
783783

784784
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchSubmit;
785-
internal override HttpMethod HttpMethod => HttpMethod.POST;
785+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
786786
internal override bool SupportsBody => true;
787787
public SubmitAsyncSearchRequestDescriptor<TDocument> SourceExcludes(Elastic.Clients.Elasticsearch.Fields? sourceExcludes) => Qs("_source_excludes", sourceExcludes);
788788
public SubmitAsyncSearchRequestDescriptor<TDocument> SourceIncludes(Elastic.Clients.Elasticsearch.Fields? sourceIncludes) => Qs("_source_includes", sourceIncludes);
@@ -1815,7 +1815,7 @@ public SubmitAsyncSearchRequestDescriptor()
18151815
}
18161816

18171817
internal override ApiUrls ApiUrls => ApiUrlsLookups.AsyncSearchSubmit;
1818-
internal override HttpMethod HttpMethod => HttpMethod.POST;
1818+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
18191819
internal override bool SupportsBody => true;
18201820
public SubmitAsyncSearchRequestDescriptor SourceExcludes(Elastic.Clients.Elasticsearch.Fields? sourceExcludes) => Qs("_source_excludes", sourceExcludes);
18211821
public SubmitAsyncSearchRequestDescriptor SourceIncludes(Elastic.Clients.Elasticsearch.Fields? sourceIncludes) => Qs("_source_includes", sourceIncludes);

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/BulkRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public BulkRequest(Elastic.Clients.Elasticsearch.IndexName? index) : base(r => r
6868
}
6969

7070
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceBulk;
71-
internal override HttpMethod HttpMethod => HttpMethod.POST;
71+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
7272
internal override bool SupportsBody => true;
7373
[JsonIgnore]
7474
public string? Pipeline { get => Q<string?>("pipeline"); set => Q("pipeline", value); }
@@ -106,7 +106,7 @@ public BulkRequestDescriptor()
106106
}
107107

108108
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceBulk;
109-
internal override HttpMethod HttpMethod => HttpMethod.POST;
109+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
110110
internal override bool SupportsBody => true;
111111
public BulkRequestDescriptor<TDocument> Source(Elastic.Clients.Elasticsearch.Core.Search.SourceConfigParam? source) => Qs("_source", source);
112112
public BulkRequestDescriptor<TDocument> SourceExcludes(Elastic.Clients.Elasticsearch.Fields? sourceExcludes) => Qs("_source_excludes", sourceExcludes);
@@ -136,7 +136,7 @@ public BulkRequestDescriptor()
136136
}
137137

138138
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceBulk;
139-
internal override HttpMethod HttpMethod => HttpMethod.POST;
139+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
140140
internal override bool SupportsBody => true;
141141
public BulkRequestDescriptor Source(Elastic.Clients.Elasticsearch.Core.Search.SourceConfigParam? source) => Qs("_source", source);
142142
public BulkRequestDescriptor SourceExcludes(Elastic.Clients.Elasticsearch.Fields? sourceExcludes) => Qs("_source_excludes", sourceExcludes);

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/ClearScrollRequest.g.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public sealed class ClearScrollRequestParameters : RequestParameters
3434
public sealed partial class ClearScrollRequest : PlainRequest<ClearScrollRequestParameters>
3535
{
3636
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceClearScroll;
37-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
37+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
3838
internal override bool SupportsBody => true;
3939
[JsonInclude]
4040
[JsonPropertyName("scroll_id")]
@@ -49,7 +49,7 @@ public ClearScrollRequestDescriptor()
4949
}
5050

5151
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceClearScroll;
52-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
52+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
5353
internal override bool SupportsBody => true;
5454
private Elastic.Clients.Elasticsearch.ScrollIds? ScrollIdValue { get; set; }
5555

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/ClosePointInTimeRequest.g.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public sealed class ClosePointInTimeRequestParameters : RequestParameters
3434
public sealed partial class ClosePointInTimeRequest : PlainRequest<ClosePointInTimeRequestParameters>
3535
{
3636
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceClosePointInTime;
37-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
37+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
3838
internal override bool SupportsBody => true;
3939
[JsonInclude]
4040
[JsonPropertyName("id")]
@@ -49,7 +49,7 @@ public ClosePointInTimeRequestDescriptor()
4949
}
5050

5151
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceClosePointInTime;
52-
internal override HttpMethod HttpMethod => HttpMethod.DELETE;
52+
protected override HttpMethod StaticHttpMethod => HttpMethod.DELETE;
5353
internal override bool SupportsBody => true;
5454
private Elastic.Clients.Elasticsearch.Id IdValue { get; set; }
5555

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/Cluster/HealthRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public HealthRequest(Elastic.Clients.Elasticsearch.Indices? indices) : base(r =>
7474
}
7575

7676
internal override ApiUrls ApiUrls => ApiUrlsLookups.ClusterHealth;
77-
internal override HttpMethod HttpMethod => HttpMethod.GET;
77+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
7878
internal override bool SupportsBody => false;
7979
[JsonIgnore]
8080
public ICollection<Elastic.Clients.Elasticsearch.ExpandWildcard>? ExpandWildcards { get => Q<ICollection<Elastic.Clients.Elasticsearch.ExpandWildcard>?>("expand_wildcards"); set => Q("expand_wildcards", value); }
@@ -118,7 +118,7 @@ public HealthRequestDescriptor()
118118
}
119119

120120
internal override ApiUrls ApiUrls => ApiUrlsLookups.ClusterHealth;
121-
internal override HttpMethod HttpMethod => HttpMethod.GET;
121+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
122122
internal override bool SupportsBody => false;
123123
public HealthRequestDescriptor<TDocument> ExpandWildcards(ICollection<Elastic.Clients.Elasticsearch.ExpandWildcard>? expandWildcards) => Qs("expand_wildcards", expandWildcards);
124124
public HealthRequestDescriptor<TDocument> Level(Elastic.Clients.Elasticsearch.Level? level) => Qs("level", level);
@@ -150,7 +150,7 @@ public HealthRequestDescriptor()
150150
}
151151

152152
internal override ApiUrls ApiUrls => ApiUrlsLookups.ClusterHealth;
153-
internal override HttpMethod HttpMethod => HttpMethod.GET;
153+
protected override HttpMethod StaticHttpMethod => HttpMethod.GET;
154154
internal override bool SupportsBody => false;
155155
public HealthRequestDescriptor ExpandWildcards(ICollection<Elastic.Clients.Elasticsearch.ExpandWildcard>? expandWildcards) => Qs("expand_wildcards", expandWildcards);
156156
public HealthRequestDescriptor Level(Elastic.Clients.Elasticsearch.Level? level) => Qs("level", level);

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/CountRequest.g.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public CountRequest(Elastic.Clients.Elasticsearch.Indices? indices) : base(r =>
8383
}
8484

8585
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceCount;
86-
internal override HttpMethod HttpMethod => HttpMethod.POST;
86+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
8787
internal override bool SupportsBody => true;
8888
[JsonIgnore]
8989
public bool? AllowNoIndices { get => Q<bool?>("allow_no_indices"); set => Q("allow_no_indices", value); }
@@ -144,7 +144,7 @@ public CountRequestDescriptor(Elasticsearch.Indices? indices) : base(r => r.Opti
144144
}
145145

146146
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceCount;
147-
internal override HttpMethod HttpMethod => HttpMethod.POST;
147+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
148148
internal override bool SupportsBody => true;
149149
public CountRequestDescriptor<TDocument> AllowNoIndices(bool? allowNoIndices = true) => Qs("allow_no_indices", allowNoIndices);
150150
public CountRequestDescriptor<TDocument> AnalyzeWildcard(bool? analyzeWildcard = true) => Qs("analyze_wildcard", analyzeWildcard);
@@ -231,7 +231,7 @@ public CountRequestDescriptor()
231231
}
232232

233233
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceCount;
234-
internal override HttpMethod HttpMethod => HttpMethod.POST;
234+
protected override HttpMethod StaticHttpMethod => HttpMethod.POST;
235235
internal override bool SupportsBody => true;
236236
public CountRequestDescriptor AllowNoIndices(bool? allowNoIndices = true) => Qs("allow_no_indices", allowNoIndices);
237237
public CountRequestDescriptor AnalyzeWildcard(bool? analyzeWildcard = true) => Qs("analyze_wildcard", analyzeWildcard);

‎src/Elastic.Clients.Elasticsearch/_Generated/Api/CreateRequest.g.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public CreateRequest(Elastic.Clients.Elasticsearch.IndexName index, Elastic.Clie
5858
}
5959

6060
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceCreate;
61-
internal override HttpMethod HttpMethod => HttpMethod.PUT;
61+
protected override HttpMethod StaticHttpMethod => HttpMethod.PUT;
6262
internal override bool SupportsBody => true;
6363
[JsonIgnore]
6464
public TDocument Document { get; set; }
@@ -105,7 +105,7 @@ internal CreateRequestDescriptor()
105105
}
106106

107107
internal override ApiUrls ApiUrls => ApiUrlsLookups.NoNamespaceCreate;
108-
internal override HttpMethod HttpMethod => HttpMethod.PUT;
108+
protected override HttpMethod StaticHttpMethod => HttpMethod.PUT;
109109
internal override bool SupportsBody => true;
110110
public CreateRequestDescriptor<TDocument> Pipeline(string? pipeline) => Qs("pipeline", pipeline);
111111
public CreateRequestDescriptor<TDocument> Refresh(Elastic.Clients.Elasticsearch.Refresh? refresh) => Qs("refresh", refresh);

0 commit comments

Comments
 (0)