Refactoring and tiny behavior fix for Ids (#7730)

Author: YohDeadfall

src/Elastic.Clients.Elasticsearch/Core/Infer/Id/Ids.cs

@@ -6,7 +6,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Text.Json;
 using System.Text.Json.Serialization;
 using Elastic.Transport;
 
@@ -22,7 +21,7 @@ public partial class Ids : IUrlParameter, IEquatable<Ids>
 
 	public Ids(IList<Id> ids) => _ids = ids;
 
-	public Ids(IEnumerable<string> ids) => _ids = ids?.Select(i  => new Id(i)).ToList();
+	public Ids(IEnumerable<string> ids) => _ids = ids.Select(i  => new Id(i)).ToList();
 
 	public Ids(string value)
 	{
@@ -84,42 +83,3 @@ public override int GetHashCode()
 
 	public static bool operator !=(Ids left, Ids right) => !Equals(left, right);
 }
-
-internal sealed class IdsConverter : JsonConverter<Ids>
-{
-	public override Ids? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-	{
-		if (reader.TokenType != JsonTokenType.StartArray)
-			throw new JsonException($"Unexpected JSON token. Expected {JsonTokenType.StartArray} but read {reader.TokenType}");
-
-		var ids = new List<Id>();
-
-		while (reader.Read() && reader.TokenType != JsonTokenType.EndArray)
-		{
-			var id = JsonSerializer.Deserialize<Id>(ref reader, options);
-
-			if (id is not null)
-				ids.Add(id);
-		}
-
-		return new Ids(ids);
-	}
-
-	public override void Write(Utf8JsonWriter writer, Ids value, JsonSerializerOptions options)
-	{
-		if (value is null)
-		{
-			writer.WriteNullValue();
-			return;
-		}
-
-		writer.WriteStartArray();
-
-		foreach (var id in value.IdsToSerialize)
-		{
-			JsonSerializer.Serialize<Id>(writer, id, options);
-		}
-
-		writer.WriteEndArray();
-	}
-}

src/Elastic.Clients.Elasticsearch/Core/Infer/Id/IdsConverter.cs

@@ -0,0 +1,49 @@
+// Licensed to Elasticsearch B.V under one or more agreements.
+// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using System.Collections.Generic;
+using System.Text.Json;
+using System.Text.Json.Serialization;
+
+namespace Elastic.Clients.Elasticsearch;
+
+internal sealed class IdsConverter : JsonConverter<Ids>
+{
+	public override Ids? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+	{
+		if (reader.TokenType != JsonTokenType.StartArray)
+			throw new JsonException($"Unexpected JSON token. Expected {JsonTokenType.StartArray} but read {reader.TokenType}");
+
+		var ids = new List<Id>();
+
+		while (reader.Read() && reader.TokenType != JsonTokenType.EndArray)
+		{
+			var id = JsonSerializer.Deserialize<Id>(ref reader, options);
+
+			if (id is not null)
+				ids.Add(id);
+		}
+
+		return new Ids(ids);
+	}
+
+	public override void Write(Utf8JsonWriter writer, Ids value, JsonSerializerOptions options)
+	{
+		if (value is null)
+		{
+			writer.WriteNullValue();
+			return;
+		}
+
+		writer.WriteStartArray();
+
+		foreach (var id in value.IdsToSerialize)
+		{
+			JsonSerializer.Serialize<Id>(writer, id, options);
+		}
+
+		writer.WriteEndArray();
+	}
+}