Skip to content

Commit 47c88be

Browse files
committed
Use MemoryStreamFactory everywhere (#4208)
Found a few places, that still new'ed MemoryStream directly (outside of client mainly) (cherry picked from commit 33476bd)
1 parent 4adb9b5 commit 47c88be

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/MockResponses/SniffResponseBytes.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@ public static byte[] Create(IEnumerable<Node> nodes, string elasticsearchVersion
1717
cluster_name = ClusterName,
1818
nodes = SniffResponseNodes(nodes, elasticsearchVersion, publishAddressOverride, randomFqdn)
1919
};
20-
using (var ms = new MemoryStream())
20+
using (var ms = RecyclableMemoryStreamFactory.Default.Create())
2121
{
22-
new LowLevelRequestResponseSerializer().Serialize(response, ms);
22+
LowLevelRequestResponseSerializer.Instance.Serialize(response, ms);
2323
return ms.ToArray();
2424
}
2525
}
2626

2727
private static IDictionary<string, object> SniffResponseNodes(
28-
IEnumerable<Node> nodes,
28+
IEnumerable<Node> nodes,
2929
string elasticsearchVersion,
30-
string publishAddressOverride,
30+
string publishAddressOverride,
3131
bool randomFqdn
3232
) =>
3333
(from node in nodes

src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/Rules/RuleBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ public TRule ReturnResponse<T>(T response)
5050
where T : class
5151
{
5252
byte[] r;
53-
using (var ms = new MemoryStream())
53+
using (var ms = RecyclableMemoryStreamFactory.Default.Create())
5454
{
55-
new LowLevelRequestResponseSerializer().Serialize(response, ms);
55+
LowLevelRequestResponseSerializer.Instance.Serialize(response, ms);
5656
r = ms.ToArray();
5757
}
5858
Self.ReturnResponse = r;

src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/VirtualClusterConnection.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,9 @@ private static byte[] CallResponse<TRule>(TRule rule)
264264
if (_defaultResponseBytes != null) return _defaultResponseBytes;
265265

266266
var response = DefaultResponse;
267-
using (var ms = new MemoryStream())
267+
using (var ms = RecyclableMemoryStreamFactory.Default.Create())
268268
{
269-
new LowLevelRequestResponseSerializer().Serialize(response, ms);
269+
LowLevelRequestResponseSerializer.Instance.Serialize(response, ms);
270270
_defaultResponseBytes = ms.ToArray();
271271
}
272272
return _defaultResponseBytes;

src/Elasticsearch.Net/Utf8Json/Internal/Emit/ILViewer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ static ILStreamReader()
6161
}
6262

6363
public ILStreamReader(byte[] ilByteArray)
64-
: base(new MemoryStream(ilByteArray))
64+
: base(RecyclableMemoryStreamFactory.Default.Create(ilByteArray))
6565
{
6666
this.endPosition = ilByteArray.Length;
6767
}

0 commit comments

Comments
 (0)