Deserialize copy_to on mapping

Ensure that all mapping types can be serialized and deserialized.
Fixes #2409

Author: russcam

src/Nest/CommonAbstractions/Infer/Field/Field.cs

@@ -125,7 +125,7 @@ string IUrlParameter.GetString(IConnectionConfigurationValues settings)
 		{
 			var nestSettings = settings as IConnectionSettingsValues;
 			if (nestSettings == null)
-				throw new Exception("Tried to pass field name on querysting but it could not be resolved because no nest settings are available");
+				throw new Exception("Tried to pass field name on querystring but it could not be resolved because no nest settings are available");
 
 			return nestSettings.Inferrer.Field(this);
 		}

src/Nest/Mapping/Types/CorePropertyBase.cs

@@ -16,6 +16,7 @@ public interface ICoreProperty : IProperty
 		Union<SimilarityOption, string> Similarity { get; set; }
 
 		[JsonProperty("copy_to")]
+		[JsonConverter(typeof(FieldsJsonConverter))]
 		Fields CopyTo { get; set; }
 	}
 

src/Nest/Modules/Indices/Fielddata/FielddataFilter.cs

@@ -4,6 +4,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[JsonConverter(typeof(ReadAsTypeJsonConverter<FielddataFilter>))]
 	public interface IFielddataFilter
 	{
 		[JsonProperty("frequency")]

src/Nest/Modules/Indices/Fielddata/FielddataFrequencyFilter.cs

@@ -3,6 +3,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[JsonConverter(typeof(ReadAsTypeJsonConverter<FielddataFrequencyFilter>))]
 	public interface IFielddataFrequencyFilter
 	{
 		[JsonProperty("min")]

src/Nest/Modules/Indices/Fielddata/FielddataRegexFilter.cs

@@ -3,6 +3,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[JsonConverter(typeof(ReadAsTypeJsonConverter<FielddataRegexFilter>))]
 	public interface IFielddataRegexFilter
 	{
 		[JsonProperty("pattern")]

src/Nest/Modules/Indices/Fielddata/Numeric/NumericFielddata.cs

@@ -3,6 +3,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[JsonConverter(typeof(ReadAsTypeJsonConverter<NumericFielddata>))]
 	public interface INumericFielddata : IFielddata
 	{
 		[JsonProperty("format")]

src/Nest/Modules/Indices/Fielddata/Numeric/NumericFielddataFormat.cs

@@ -1,7 +1,10 @@
 using System.Runtime.Serialization;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 
 namespace Nest
 {
+	[JsonConverter(typeof(StringEnumConverter))]
 	public enum NumericFielddataFormat
 	{
 		[EnumMember(Value = "array")]

src/Nest/Modules/Indices/Fielddata/String/StringFielddata.cs

@@ -3,6 +3,7 @@
 namespace Nest
 {
 	[JsonObject(MemberSerialization.OptIn)]
+	[JsonConverter(typeof(ReadAsTypeJsonConverter<StringFielddata>))]
 	public interface IStringFielddata : IFielddata
 	{
 		[JsonProperty("format")]

src/Tests/Mapping/Types/Core/Text/TextPropertyTests.cs

@@ -20,8 +20,23 @@ public TextPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(cl
 					type = "text",
 					analyzer = "standard",
 					boost = 1.2,
+					copy_to = new [] { "other_field" },
 					eager_global_ordinals = true,
 					fielddata = true,
+					fielddata_frequency_filter = new
+					{
+						min = 1.0,
+						max = 100.00,
+						min_segment_size = 2
+					},
+					fields = new
+					{
+						raw = new
+						{
+							type = "keyword",
+							ignore_above = 100
+						}
+					},
 					include_in_all = false,
 					index = true,
 					index_options = "offsets",
@@ -41,8 +56,22 @@ public TextPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(cl
 					.Name(p => p.Name)
 					.Analyzer("standard")
 					.Boost(1.2)
+					.CopyTo(c => c
+						.Field("other_field")
+					)
 					.EagerGlobalOrdinals()
 					.Fielddata()
+					.FielddataFrequencyFilter(ff => ff
+						.Min(1)
+						.Max(100)
+						.MinSegmentSize(2)
+					)
+					.Fields(fd => fd
+						.Keyword(k => k
+							.Name("raw")
+							.IgnoreAbove(100)
+						)
+					)
 					.IncludeInAll(false)
 					.Index(true)
 					.IndexOptions(IndexOptions.Offsets)
@@ -61,8 +90,23 @@ public TextPropertyTests(WritableCluster cluster, EndpointUsage usage) : base(cl
 				{
 					Analyzer = "standard",
 					Boost = 1.2,
+					CopyTo = "other_field",
 					EagerGlobalOrdinals = true,
 					Fielddata = true,
+					FielddataFrequencyFilter = new FielddataFrequencyFilter
+					{
+						Min = 1,
+						Max = 100,
+						MinSegmentSize = 2
+					},
+					Fields = new Properties
+					{
+						{ "raw", new KeywordProperty
+							{
+								IgnoreAbove = 100
+							}
+						}
+					},
 					IncludeInAll = false,
 					Index = true,
 					IndexOptions = IndexOptions.Offsets,

src/Tests/Reproduce/GithubIssue2409.cs

@@ -0,0 +1,49 @@
+using System;
+using System.Linq;
+using System.Text;
+using Elasticsearch.Net;
+using FluentAssertions;
+using Nest;
+using Tests.Framework;
+using Tests.Indices.MappingManagement.GetMapping;
+using Xunit;
+
+namespace Tests.Reproduce
+{
+	public class GithubIssue2409
+	{
+		[U]
+		public void CanDeserializeCopyTo()
+		{
+			var json = "{\"test-events-v1-201412\":{\"mappings\":{\"events\":{\"dynamic\":\"false\",\"_size\":{\"enabled\":true},\"properties\":{\"created_utc\":{\"type\":\"date\"},\"data\":{\"properties\":{\"@environment\":{\"properties\":{\"o_s_name\":{\"type\":\"text\",\"index\":false,\"copy_to\":[\"os\"]}}}}},\"id\":{\"type\":\"keyword\"},\"os\":{\"type\":\"text\",\"fields\":{\"keyword\":{\"type\":\"keyword\",\"ignore_above\":256}}}}}}},\"test-events-v1-201502\":{\"mappings\":{\"events\":{\"dynamic\":\"false\",\"_size\":{\"enabled\":true},\"properties\":{\"created_utc\":{\"type\":\"date\"},\"data\":{\"properties\":{\"@environment\":{\"properties\":{\"o_s_name\":{\"type\":\"text\",\"index\":false,\"copy_to\":[\"os\"]}}}}},\"id\":{\"type\":\"keyword\"},\"os\":{\"type\":\"text\",\"fields\":{\"keyword\":{\"type\":\"keyword\",\"ignore_above\":256}}}}}}}}";
+
+			var pool = new SingleNodeConnectionPool(new Uri("http://localhost:9200"));
+
+			var connection = new InMemoryConnection(Encoding.UTF8.GetBytes(json));
+			var settings = new ConnectionSettings(pool, connection).DefaultIndex("test-events-v1-201412");
+			var client = new ElasticClient(settings);
+
+			var mappingResponse = client.GetMapping<Events>();
+
+			mappingResponse.IsValid.Should().BeTrue();
+
+			var mappingWalker = new MappingWalker(new CopyToVisitor());
+			mappingWalker.Accept(mappingResponse);
+		}
+
+		public class CopyToVisitor : NoopMappingVisitor
+		{
+			public override void Visit(ITextProperty property)
+			{
+				if (property.Name == "o_s_name")
+				{
+					property.CopyTo.Should().NotBeNull();
+				}
+			}
+		}
+
+		public class Events
+		{
+		}
+	}
+}

src/Tests/Tests.csproj

@@ -624,6 +624,7 @@
     <Compile Include="Reproduce\GithubIssue2306.cs" />
     <Compile Include="Reproduce\GithubIssue2309.cs" />
     <Compile Include="Reproduce\GithubIssue2323.cs" />
+    <Compile Include="Reproduce\GithubIssue2409.cs" />
     <Compile Include="Search\Hits\HitsSerializationTests.cs" />
     <Compile Include="Search\MultiSearch\MultiSearchApiTests.cs" />
     <Compile Include="Search\MultiSearch\MultiSearchInvalidApiTests.cs" />

src/Tests/tests.yaml

@@ -1,5 +1,5 @@
 # mode either u (unit test), i (integration test) or m (mixed mode)
-mode: i
+mode: m
 # the elasticsearch version that should be started
 # Can be a snapshot version of sonatype or "latest" to get the latest snapshot of sonatype
 elasticsearch_version: 5.0.1