From e984110cc9d47f250627b1a2a65e5756abbff207 Mon Sep 17 00:00:00 2001 From: Sylvain Wallez Date: Tue, 25 Jan 2022 17:46:46 +0100 Subject: [PATCH] Add tests for compact ErrorCause (#133) --- .../elasticsearch/ElasticsearchTestServer.java | 4 ++++ .../elasticsearch/spec_issues/SpecIssuesTest.java | 11 +++++++++++ 2 files changed, 15 insertions(+) diff --git a/java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java b/java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java index 56a4bc9e1..ca5e79538 100644 --- a/java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java +++ b/java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java @@ -108,4 +108,8 @@ public JsonpMapper mapper() { public ElasticsearchClient client() { return client; } + + public ElasticsearchAsyncClient asyncClient() { + return new ElasticsearchAsyncClient(client._transport(), client._transportOptions()); + } } diff --git a/java-client/src/test/java/co/elastic/clients/elasticsearch/spec_issues/SpecIssuesTest.java b/java-client/src/test/java/co/elastic/clients/elasticsearch/spec_issues/SpecIssuesTest.java index ee3a6aeb6..a5dce6d11 100644 --- a/java-client/src/test/java/co/elastic/clients/elasticsearch/spec_issues/SpecIssuesTest.java +++ b/java-client/src/test/java/co/elastic/clients/elasticsearch/spec_issues/SpecIssuesTest.java @@ -20,6 +20,7 @@ package co.elastic.clients.elasticsearch.spec_issues; import co.elastic.clients.elasticsearch.ElasticsearchTestServer; +import co.elastic.clients.elasticsearch._types.ErrorResponse; import co.elastic.clients.elasticsearch.cluster.ClusterStatsResponse; import co.elastic.clients.elasticsearch.core.SearchRequest; import co.elastic.clients.elasticsearch.core.SearchResponse; @@ -61,7 +62,17 @@ public void i0087_filterAggSubAggregation() { resp.aggregations().get("login_filter").filter() .aggregations().get("to_domain").sterms() .buckets().array().get(0).key()); + } + + @Test + public void i0080_simpleError() { + // https://github.com/elastic/elasticsearch-java/issues/80 + // When requesting a missing index, the error response in compact format. + // Fixed by adding ErrorCause.reason as a shortcut property + String json = "{\"error\":\"alias [not-existing-alias] missing\",\"status\":404}"; + ErrorResponse err = fromJson(json, ErrorResponse.class); + assertEquals("alias [not-existing-alias] missing", err.error().reason()); } @Test