Skip to content

ElasticsearchClient._transportOptions() should not return null #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
swallez opened this issue Mar 17, 2022 · 1 comment
Open

ElasticsearchClient._transportOptions() should not return null #206

swallez opened this issue Mar 17, 2022 · 1 comment
Labels
Category: Bug Something isn't working Category: Enhancement New feature or request

Comments

@swallez
Copy link
Member

swallez commented Mar 17, 2022 •
edited
Loading

Java API client version

7.16

Java version

all

Elasticsearch Version

all

Problem description

ElasticsearchClient._transportOptions() returns null if no options were set on the client.

It would be more convenient to have this method default to returning the underlying transport's option in that case.

Similary it would be more convient to have withTransportOptions accept a builder lambda that augments existing options.
@swallez swallez added the Category: Bug Something isn't working label Mar 17, 2022
@swallez swallez changed the title ElasticsearchClient. ElasticsearchClient._transportOptions() should not return null Mar 17, 2022
@swallez swallez added the Category: Enhancement New feature or request label Mar 17, 2022
@swallez swallez mentioned this issue Mar 17, 2022
Closed
@tongdaoqa
Copy link

upvoting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Bug Something isn't working Category: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swallez @tongdaoqa