Skip to content

Commit b4a97c1

Browse files
committed
1 parent ba49177 commit b4a97c1

File tree

7 files changed

+43
-22
lines changed

7 files changed

+43
-22
lines changed

examples/Elastic.Extensions.Logging.Example/Elastic.Extensions.Logging.Example.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<ItemGroup>
1111
<PackageReference Include="Microsoft.Extensions.Hosting" Version="3.1.6" />
12-
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.0" />
12+
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.3" />
1313
<PackageReference Include="NEST" Version="7.8.1" />
1414
</ItemGroup>
1515

examples/Elastic.Serilog.Sinks.Example/Elastic.Serilog.Sinks.Example.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<PackageReference Include="Elastic.Apm" Version="1.22.0" />
1212
<PackageReference Include="Serilog" Version="2.10.0" />
1313
<PackageReference Include="Microsoft.Extensions.Hosting" Version="7.0.0" />
14-
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.0" />
14+
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.3" />
1515
<PackageReference Include="Elastic.Clients.Elasticsearch" Version="8.0.4" />
1616
<PackageReference Include="Serilog.Extensions.Hosting" Version="5.0.1" />
1717
<PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />

examples/aspnetcore-with-extensions-logging/aspnetcore-with-extensions-logging.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</PropertyGroup>
99

1010
<ItemGroup>
11-
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.0" />
11+
<PackageReference Include="Elastic.Elasticsearch.Ephemeral" Version="0.4.3" />
1212
<PackageReference Include="Elastic.Clients.Elasticsearch" Version="8.0.4" />
1313
</ItemGroup>
1414

tests-integration/Elastic.Serilog.Sinks.IntegrationTests/SerilogCluster.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
using Elastic.Elasticsearch.Ephemeral;
2+
using Elastic.Elasticsearch.Xunit;
13
using Elasticsearch.IntegrationDefaults;
24
using Xunit;
35

@@ -8,4 +10,13 @@ namespace Elastic.Serilog.Sinks.IntegrationTests;
810
public class SerilogCluster : TestClusterBase
911
{
1012
public SerilogCluster() : base(9205) { }
13+
protected SerilogCluster(int port, ClusterFeatures features) : base(port, features) { }
14+
}
15+
16+
public class SecurityCluster : SerilogCluster
17+
{
18+
public SecurityCluster() : base(9206, ClusterFeatures.XPack | ClusterFeatures.Security | ClusterFeatures.SSL)
19+
{
20+
21+
}
1122
}

tests-integration/Elastic.Serilog.Sinks.IntegrationTests/SerilogTestBase.cs

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,22 @@
22
using System.Collections.Generic;
33
using Elastic.Clients.Elasticsearch;
44
using Elastic.Elasticsearch.Xunit.XunitPlumbing;
5+
using Elasticsearch.IntegrationDefaults;
56
using Xunit.Abstractions;
67

7-
namespace Elastic.Serilog.Sinks.IntegrationTests
8+
namespace Elastic.Serilog.Sinks.IntegrationTests;
9+
10+
public abstract class SerilogTestBase<TCluster> : IClusterFixture<TCluster>
11+
where TCluster : TestClusterBase, new()
812
{
9-
public abstract class SerilogTestBase : IClusterFixture<SerilogCluster>
10-
{
11-
protected ElasticsearchClient Client { get; }
13+
protected ElasticsearchClient Client { get; }
1214

13-
protected SerilogTestBase(SerilogCluster cluster, ITestOutputHelper output, Func<ICollection<Uri>, ICollection<Uri>>? alterNodes = null) =>
14-
Client = cluster.CreateClient(output, alterNodes);
15-
}
15+
protected SerilogTestBase(SerilogCluster cluster, ITestOutputHelper output, Func<ICollection<Uri>, ICollection<Uri>>? alterNodes = null) =>
16+
Client = cluster.CreateClient(output, alterNodes);
17+
}
1618

19+
public abstract class SerilogTestBase : SerilogTestBase<SerilogCluster>
20+
{
21+
protected SerilogTestBase(SerilogCluster cluster, ITestOutputHelper output, Func<ICollection<Uri>, ICollection<Uri>>? alterNodes = null)
22+
: base(cluster, output, alterNodes) { }
1723
}

tests-integration/Elasticsearch.IntegrationDefaults/Elasticsearch.IntegrationDefaults.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<ItemGroup>
1212
<PackageReference Include="Elastic.Clients.Elasticsearch" Version="8.0.4" />
13-
<PackageReference Include="Elastic.Elasticsearch.Xunit" Version="0.4.0" />
13+
<PackageReference Include="Elastic.Elasticsearch.Xunit" Version="0.4.3" />
1414
<PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.5.3" />
1515

1616
</ItemGroup>

tests-integration/Elasticsearch.IntegrationDefaults/IngestionCluster.cs

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
33
// See the LICENSE file in the project root for more information
44

5+
using System.Net.Security;
56
using Elastic.Clients.Elasticsearch;
7+
using Elastic.Elasticsearch.Ephemeral;
68
using Elastic.Elasticsearch.Xunit;
79
using Elastic.Transport;
810
using Xunit;
911
using Xunit.Abstractions;
12+
using static Elastic.Elasticsearch.Managed.DetectedProxySoftware;
1013

1114
[assembly: TestFramework("Elastic.Elasticsearch.Xunit.Sdk.ElasticTestFramework", "Elastic.Elasticsearch.Xunit")]
1215

@@ -15,24 +18,19 @@ namespace Elasticsearch.IntegrationDefaults
1518
/// <summary> Declare our cluster that we want to inject into our test classes </summary>
1619
public abstract class TestClusterBase : XunitClusterBase
1720
{
18-
protected TestClusterBase(int port = 9200) : base(new XunitClusterConfiguration("8.4.0")
19-
{
20-
StartingPortNumber = port
21-
}) { }
21+
protected TestClusterBase(int port = 9200, ClusterFeatures features = ClusterFeatures.None)
22+
: base(new XunitClusterConfiguration("8.4.0", features) { StartingPortNumber = port, AutoWireKnownProxies = true }) { }
2223

2324
public ElasticsearchClient CreateClient(ITestOutputHelper output, Func<ICollection<Uri>, ICollection<Uri>>? alterNodes = null) =>
24-
this.GetOrAddClient(_ =>
25+
this.GetOrAddClient(cluster =>
2526
{
26-
var hostName = (System.Diagnostics.Process.GetProcessesByName("mitmproxy").Any()
27-
? "ipv4.fiddler"
28-
: "localhost");
29-
var nodes = NodesUris(hostName);
27+
var isCi = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CI"));
28+
var nodes = NodesUris();
3029
if (alterNodes != null) nodes = alterNodes(nodes);
3130
var connectionPool = new StaticNodePool(nodes);
32-
var isCi = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CI"));
3331
var settings = new ElasticsearchClientSettings(connectionPool)
34-
.Proxy(new Uri("http://ipv4.fiddler:8080"), null!, null!)
3532
.RequestTimeout(TimeSpan.FromSeconds(5))
33+
.ServerCertificateValidationCallback(CertificateValidations.AllowAll)
3634
.OnRequestCompleted(d =>
3735
{
3836
try
@@ -54,6 +52,12 @@ public ElasticsearchClient CreateClient(ITestOutputHelper output, Func<ICollecti
5452
.EnableDebugMode()
5553
//do not request server stack traces on CI, too noisy
5654
.IncludeServerStackTraceOnError(!isCi);
55+
if (cluster.DetectedProxy != None)
56+
{
57+
var proxyUrl = cluster.DetectedProxy == Fiddler ? "ipv4.fiddler" : "localhost";
58+
settings = settings.Proxy(new Uri($"http://{proxyUrl}:8080"), null!, null!);
59+
}
60+
5761
return new ElasticsearchClient(settings);
5862
});
5963
}

0 commit comments

Comments
 (0)