Skip to content

Commit 3fb7c35

Browse files
committed
Fix memory units for dorpwizard metrics-jvm
In case dropwizard is used the heap metrics are in bytes and not in kilobytes. This is deteceted by the presence of heap.max. For Spring Boot 2.0 there is an issue filed to deliver bytes see spring-projects/spring-boot#6413 fixes #234
1 parent c09779a commit 3fb7c35

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

spring-boot-admin-server-ui/modules/applications-details/components/memoryStats.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,26 @@ module.exports = {
2626
ctrl.$onChanges = function () {
2727
ctrl.memory = {
2828
total: ctrl.metrics.mem,
29-
used: ctrl.metrics.mem - ctrl.metrics['mem.free']
29+
used: ctrl.metrics.mem - ctrl.metrics['mem.free'],
30+
unit: 'K'
3031
};
3132
ctrl.memory.percentUsed = $filter('number')(ctrl.memory.used / ctrl.memory.total * 100, 2);
3233

3334
ctrl.heap = {
3435
total: ctrl.metrics['heap.committed'],
3536
used: ctrl.metrics['heap.used'],
3637
init: ctrl.metrics['heap.init'],
37-
max: ctrl.metrics.heap
38+
max: ctrl.metrics['heap.max'] || ctrl.metrics.heap,
39+
unit: ctrl.metrics['heap.max'] ? 'B' : 'K'
3840
};
3941
ctrl.heap.percentUsed = $filter('number')(ctrl.heap.used / ctrl.heap.total * 100, 2);
4042

4143
ctrl.nonheap = {
4244
total: ctrl.metrics['nonheap.committed'],
4345
used: ctrl.metrics['nonheap.used'],
4446
init: ctrl.metrics['nonheap.init'],
45-
max: ctrl.metrics.nonheap
47+
max: ctrl.metrics.nonheap,
48+
unit: 'K'
4649
};
4750
ctrl.nonheap.percentUsed = $filter('number')(ctrl.nonheap.used / ctrl.nonheap.total * 100, 2);
4851
};
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
<table class="table">
22
<tr>
3-
<td colspan="2"> <span>Memory ({{ $ctrl.memory.used | humanBytes:'K' }} / {{ $ctrl.memory.total | humanBytes:'K' }})</span>
3+
<td colspan="2"> <span>Memory ({{ $ctrl.memory.used | humanBytes:$ctrl.memory.unit }} / {{ $ctrl.memory.total | humanBytes:$ctrl.memory.unit }})</span>
44
<div class="progress" style="margin-bottom: 0px;">
55
<div class="bar" ng-class="$ctrl.getBarClass($ctrl.memory.percentUsed)" style="width: {{$ctrl.memory.percentUsed}}%;">{{$ctrl.memory.percentUsed}}%</div>
66
</div>
77
</td>
88
</tr>
99
<tr>
10-
<td colspan="2"> <span>Heap Memory ({{ $ctrl.heap.used | humanBytes:'K' }} / {{ $ctrl.heap.total | humanBytes:'K' }})</span>
10+
<td colspan="2"> <span>Heap Memory ({{ $ctrl.heap.used | humanBytes:$ctrl.heap.unit }} / {{ $ctrl.heap.total | humanBytes:$ctrl.heap.unit }})</span>
1111
<div class="progress" style="margin-bottom: 0px;">
1212
<div class="bar" ng-class="$ctrl.getBarClass($ctrl.heap.percentUsed)" style="width: {{$ctrl.heap.percentUsed}}%;">{{$ctrl.heap.percentUsed}}%</div>
1313
</div>
1414
</td>
1515
</tr>
1616
<tr>
1717
<td>Initial Heap (-Xms)</td>
18-
<td>{{$ctrl.heap.init | humanBytes:'K' }}</td>
18+
<td>{{$ctrl.heap.init | humanBytes:$ctrl.heap.unit }}</td>
1919
</tr>
2020
<tr>
2121
<td>Maximum Heap (-Xmx)</td>
22-
<td>{{$ctrl.heap.max | humanBytes:'K' }}</td>
22+
<td>{{$ctrl.heap.max | humanBytes:$ctrl.heap.unit }}</td>
2323
</tr>
2424
<tr>
25-
<td colspan="2"> <span>Non-Heap Memory ({{ $ctrl.nonheap.used | humanBytes:'K' }} / {{ $ctrl.nonheap.total | humanBytes:'K' }})</span>
25+
<td colspan="2"> <span>Non-Heap Memory ({{ $ctrl.nonheap.used | humanBytes:$ctrl.nonheap.unit }} / {{ $ctrl.nonheap.total | humanBytes:$ctrl.nonheap.unit }})</span>
2626
<div class="progress" style="margin-bottom: 0px;">
2727
<div class="bar" ng-class="$ctrl.getBarClass($ctrl.nonheap.percentUsed)" style="width: {{$ctrl.nonheap.percentUsed}}%;">{{$ctrl.nonheap.percentUsed}}%</div>
2828
</div>
2929
</td>
3030
</tr>
3131
<tr>
3232
<td>Initial Non-Heap</td>
33-
<td>{{$ctrl.nonheap.init | humanBytes:'K' }}</td>
33+
<td>{{$ctrl.nonheap.init | humanBytes:$ctrl.nonheap.unit }}</td>
3434
</tr>
3535
<tr>
3636
<td>Maximum Non-Heap</td>
37-
<td ng-show="$ctrl.nonheap.max > 0">{{$ctrl.nonheap.max | humanBytes:'K' }}</td>
37+
<td ng-show="$ctrl.nonheap.max > 0">{{$ctrl.nonheap.max | humanBytes:$ctrl.nonheap.unit }}</td>
3838
<td ng-show="$ctrl.nonheap.max <= 0">unbounded</td>
3939
</tr>
4040
</table>

0 commit comments

Comments
 (0)