Merge pull request scala#8396 from retronym/topic/reflection-thread-safety-tycon

A pair of thread safety fixes for runtime reflection.

Author: adriaanm

src/reflect/mima-filters/2.12.0.backwards.excludes

@@ -18,4 +18,5 @@ ProblemFilters.exclude[MissingTypesProblem]("scala.reflect.runtime.JavaUniverse"
 ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.reflect.io.ZipArchive.close")
 
 ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.reflect.io.ZipArchive.getDir")
-ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.io.FileZipArchive.allDirs")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.io.FileZipArchive.allDirs")
+ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.reflect.runtime.SynchronizedSymbols#SynchronizedSymbol.scala$reflect$runtime$SynchronizedSymbols$SynchronizedSymbol$$super$typeConstructor")

src/reflect/mima-filters/2.12.0.forwards.excludes

@@ -41,4 +41,5 @@ ProblemFilters.exclude[DirectMissingMethodProblem]("scala.reflect.api.Universe.T
 ProblemFilters.exclude[MissingClassProblem]("scala.reflect.macros.Attachments$")
 
 ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.reflect.io.ZipArchive.getDir")
-ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.io.FileZipArchive.allDirs")
+ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.io.FileZipArchive.allDirs")
+ProblemFilters.exclude[DirectMissingMethodProblem]("scala.reflect.runtime.SynchronizedSymbols#SynchronizedSymbol.typeConstructor")

src/reflect/scala/reflect/internal/Types.scala

@@ -111,12 +111,11 @@ trait Types
   private object substTypeMapCache {
     private[this] var cached: SubstTypeMap = new SubstTypeMap(Nil, Nil)
 
-    def apply(from: List[Symbol], to: List[Type]): SubstTypeMap = {
+    def apply(from: List[Symbol], to: List[Type]): SubstTypeMap = if (isCompilerUniverse) {
       if ((cached.from ne from) || (cached.to ne to))
         cached = new SubstTypeMap(from, to)
-
       cached
-    }
+    } else new SubstTypeMap(from, to)
   }
 
   /** The current skolemization level, needed for the algorithms

src/reflect/scala/reflect/runtime/SynchronizedSymbols.scala

@@ -160,6 +160,7 @@ private[reflect] trait SynchronizedSymbols extends internal.Symbols { self: Symb
     override def exists: Boolean = gilSynchronizedIfNotThreadsafe(super.exists)
     override def typeSignature: Type = gilSynchronizedIfNotThreadsafe { super.typeSignature }
     override def typeSignatureIn(site: Type): Type = gilSynchronizedIfNotThreadsafe { super.typeSignatureIn(site) }
+    override def typeConstructor: Type = gilSynchronizedIfNotThreadsafe { super.typeConstructor }
 
     override def typeParams: List[Symbol] = gilSynchronizedIfNotThreadsafe {
       if (isCompilerUniverse) super.typeParams

test/junit/scala/reflect/runtime/ThreadSafetyTest.scala

@@ -0,0 +1,103 @@
+/*
+ * Scala (https://www.scala-lang.org)
+ *
+ * Copyright EPFL and Lightbend, Inc.
+ *
+ * Licensed under Apache License 2.0
+ * (http://www.apache.org/licenses/LICENSE-2.0).
+ *
+ * See the NOTICE file distributed with this work for
+ * additional information regarding copyright ownership.
+ */
+
+package scala.reflect.runtime
+
+import java.util.concurrent.{Callable, Executors}
+
+import org.junit.Test
+
+class ThreadSafetyTest {
+  import scala.reflect.runtime.universe._
+  sealed abstract class Instance(tp: Type)
+  final case class ListInstance(tp: Type, elemInstance: Instance) extends Instance(appliedType(symbolOf[List[_]], tp :: Nil))
+
+  final case class DoubleInstance() extends Instance(typeOf[Double])
+
+  final case class StringInstance() extends Instance(typeOf[String])
+
+  final case class LowPriorityInstance(tpe: Type) extends Instance(tpe)
+
+  def classKeyOf[T: TypeTag]: String = {
+    classKeyOf(typeOf[T])
+  }
+  def classKeyOf(tpe: Type): String = {
+    tpe.typeSymbol.fullName
+  }
+
+  class Lazy[T](thunk: () => T) {
+    lazy val force: T = thunk()
+  }
+
+  class Registry {
+    private val cache = new java.util.concurrent.ConcurrentHashMap[Type, Lazy[Instance]]()
+    def instance[T: TypeTag]: Lazy[Instance] = {
+      instance(typeOf[T])
+    }
+    def instance(tpe: Type): Lazy[Instance] = {
+      val value = keyOf(tpe)
+      assert(value =:= tpe, (value, tpe))
+      cache.computeIfAbsent(value, create(_))
+    }
+
+    private def create(tpe: Type): Lazy[Instance] = {
+      val key = classKeyOf(tpe)
+      if (key == "scala.collection.immutable.List") {
+        new Lazy(() => {val elemTpe = tpe.dealias.typeArgs.head; ListInstance(tpe.dealias, instance(elemTpe).force)})
+      } else if (key == "scala.Double") {
+        new Lazy(() => DoubleInstance())
+      } else if (key == "java.lang.String") {
+        new Lazy(() => StringInstance())
+      } else {
+        new Lazy(() => LowPriorityInstance(tpe))
+      }
+    }
+    private def keyOf(tp: Type): universe.Type = {
+      tp.map(_.dealias)
+    }
+  }
+
+  @Test
+  def test(): Unit = {
+    val executor = Executors.newFixedThreadPool(16)
+    for (i <- (0 to 128)) {
+      val registry = new Registry
+      val is = List(
+        (() => typeOf[List[Double]], "ListInstance(List[Double],DoubleInstance())"),
+        (() => typeOf[List[String]], "ListInstance(List[String],StringInstance())"),
+        (() => typeOf[List[List[Double]]], "ListInstance(List[List[Double]],ListInstance(List[Double],DoubleInstance()))"),
+        (() => typeOf[List[List[List[Double]]]], "ListInstance(List[List[List[Double]]],ListInstance(List[List[Double]],ListInstance(List[Double],DoubleInstance())))"),
+        (() => typeOf[List[List[List[Object]]]], "ListInstance(List[List[List[Object]]],ListInstance(List[List[Object]],ListInstance(List[Object],LowPriorityInstance(Object))))")
+      )
+      sealed abstract class Result
+      case object Okay extends Result
+      case class Failed(i: Int, tp: Type, expected: String, instance: String) extends Result
+      def check(i: Int): Result = {
+        val (f, expected) = is(i % is.size)
+        val tp = f()
+        val instance = registry.instance(tp).force
+        if (instance.toString == expected) Okay else Failed(i, tp, expected, "[" + instance + "]")
+      }
+      val par = true
+      val fs: List[Result] = if (par) Array.tabulate(32)(i =>
+        executor.submit(new Callable[Result] {
+          override def call(): Result = {
+            check(i % is.size)
+          }
+        })).map(_.get).toList
+      else is.indices.map(check).toList
+      val fails = fs.filter(_ != Okay)
+      assert(fails.isEmpty, "iteration " + i + ": " + fails.mkString("\n"))
+    }
+    executor.shutdownNow()
+  }
+}