Skip to content

Commit 42dbc6c

Browse files
authored
aerospikereceiver: Add missing units in metadata.yaml (open-telemetry#23572)
Metric unit is required, see: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/mdatagen/metadata-schema.yaml#L72-L73. This PR adds the unit to metrics where this is missing: - aerospike.node.query.tracked
1 parent 200778b commit 42dbc6c

File tree

6 files changed

+341
-318
lines changed

6 files changed

+341
-318
lines changed
+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Use this changelog template to create an entry for release notes.
2+
# If your change doesn't affect end users, such as a test fix or a tooling change,
3+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
4+
5+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
6+
change_type: enhancement
7+
8+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
9+
component: aerospikereceiver
10+
11+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
12+
note: Adds unit to metrics where this was missing.
13+
14+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
15+
issues: [23572]
16+
17+
# (Optional) One or more lines of additional information to render under the primary note.
18+
# These lines will be padded with 2 spaces and then inserted directly into the document.
19+
# Use pipe (|) for multiline entries.
20+
subtext: |
21+
Affected metrics can be found below.
22+
- aerospike.node.query.tracked

receiver/aerospikereceiver/documentation.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ Number of queries which ran more than query untracked_time (default 1 sec), Aero
189189
190190
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
191191
| ---- | ----------- | ---------- | ----------------------- | --------- |
192-
| | Sum | Int | Cumulative | true |
192+
| {queries} | Sum | Int | Cumulative | true |
193193
194194
## Resource Attributes
195195

receiver/aerospikereceiver/internal/metadata/generated_metrics.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/aerospikereceiver/internal/metadata/generated_metrics_test.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/aerospikereceiver/metadata.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ metrics:
141141
enabled: true
142142
description: Number of queries tracked by the system.
143143
extended_documentation: Number of queries which ran more than query untracked_time (default 1 sec), Aerospike metric query_tracked
144+
unit: '{queries}'
144145
sum:
145146
value_type: int
146147
input_type: string

0 commit comments

Comments
 (0)