Skip to content

Commit 31bfef7

Browse files
author
Alex Boten
authored
[chore] bump go version for linting (open-telemetry#23346)
After digging into what was causing linting time outs, it looks like golangci-lint was using up a significant amount of memory to run lint against otelcontribcol. After digging I came across this issue that mentions memory usage: golangci/golangci-lint#3565 (comment) I've tested bumping the linters to go 1.20 and so far it looks like the avg memory is lower than it was w/ go 1.19. I've also enabled verbose logging for linting to give us a bit more info when there are issues. --------- Signed-off-by: Alex Boten <[email protected]>
1 parent d79f3c0 commit 31bfef7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/build-and-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
- uses: actions/checkout@v3
7979
- uses: actions/setup-go@v4
8080
with:
81-
go-version: 1.19
81+
go-version: "1.20"
8282
cache: false
8383
- name: Cache Go
8484
id: go-cache

Makefile.Common

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ fmt: $(GOIMPORTS)
155155

156156
.PHONY: lint
157157
lint: $(LINT) checklicense misspell
158-
$(LINT) run --allow-parallel-runners --build-tags integration --path-prefix $(shell basename "$(CURDIR)")
158+
$(LINT) run --allow-parallel-runners --verbose --build-tags integration --path-prefix $(shell basename "$(CURDIR)")
159159

160160
.PHONY: govulncheck
161161
govulncheck: $(GOVULNCHECK)

0 commit comments

Comments
 (0)