HTTPClient - Fix case sensitivity for header keys (#2185)

earlephilhower · web-flow · commit 3839f07afe0f · 2024-05-30T13:05:49.000-07:00
From espressif/arduino-esp32#8713
diff --git a/libraries/HTTPClient/src/HTTPClient.cpp b/libraries/HTTPClient/src/HTTPClient.cpp
@@ -955,7 +955,7 @@ void HTTPClient::collectHeaders(const char* headerKeys[], const size_t headerKey
 
 String HTTPClient::header(const char* name) {
     for (size_t i = 0; i < _headerKeysCount; ++i) {
-        if (_currentHeaders[i].key == name) {
+        if (_currentHeaders[i].key.equalsIgnoreCase(name)) {
             return _currentHeaders[i].value;
         }
     }
@@ -982,7 +982,7 @@ int HTTPClient::headers() {
 
 bool HTTPClient::hasHeader(const char* name) {
     for (size_t i = 0; i < _headerKeysCount; ++i) {
-        if ((_currentHeaders[i].key == name) && (_currentHeaders[i].value.length() > 0)) {
+        if ((_currentHeaders[i].key.equalsIgnoreCase(name)) && (_currentHeaders[i].value.length() > 0)) {
             return true;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,7 @@ void HTTPClient::collectHeaders(const char* headerKeys[], const size_t headerKey`
`955`	`955`
`956`	`956`	`String HTTPClient::header(const char* name) {`
`957`	`957`	`for (size_t i = 0; i < _headerKeysCount; ++i) {`
`958`		`- if (_currentHeaders[i].key == name) {`
	`958`	`+ if (_currentHeaders[i].key.equalsIgnoreCase(name)) {`
`959`	`959`	`return _currentHeaders[i].value;`
`960`	`960`	`}`
`961`	`961`	`}`
`@@ -982,7 +982,7 @@ int HTTPClient::headers() {`
`982`	`982`
`983`	`983`	`bool HTTPClient::hasHeader(const char* name) {`
`984`	`984`	`for (size_t i = 0; i < _headerKeysCount; ++i) {`
`985`		`- if ((_currentHeaders[i].key == name) && (_currentHeaders[i].value.length() > 0)) {`
	`985`	`+ if ((_currentHeaders[i].key.equalsIgnoreCase(name)) && (_currentHeaders[i].value.length() > 0)) {`
`986`	`986`	`return true;`
`987`	`987`	`}`
`988`	`988`	`}`