ensure to dispatch Series.equals to EA.equals

Author: jorisvandenbossche

pandas/core/internals/blocks.py

@@ -1861,6 +1861,11 @@ def where(
 
         return [self.make_block_same_class(result, placement=self.mgr_locs)]
 
+    def equals(self, other) -> bool:
+        if self.dtype != other.dtype or self.shape != other.shape:
+            return False
+        return self.values.equals(other.values)
+
     def _unstack(self, unstacker, fill_value, new_placement):
         # ExtensionArray-safe unstack.
         # We override ObjectBlock._unstack, which unstacks directly on the

pandas/tests/extension/base/methods.py

@@ -422,14 +422,19 @@ def test_repeat_raises(self, data, repeats, kwargs, error, msg, use_numpy):
             else:
                 data.repeat(repeats, **kwargs)
 
-    def test_equals(self, data, na_value):
+    def test_equals(self, data, na_value, as_series):
         data2 = type(data)._from_sequence([data[0]] * len(data), dtype=data.dtype)
         data_na = type(data)._from_sequence([na_value] * len(data), dtype=data.dtype)
 
+        if as_series:
+            data = pd.Series(data)
+            data2 = pd.Series(data2)
+            data_na = pd.Series(data_na)
+
         assert data.equals(data) is True
         assert data.equals(data.copy()) is True
 
-        # other data
+        # unequal other data
         assert data.equals(data2) is False
         assert data.equals(data_na) is False
 
@@ -442,19 +447,3 @@ def test_equals(self, data, na_value):
         # other types
         assert data.equals(None) is False
         assert data[[0]].equals(data[0]) is False
-
-        # TODO test series
-        # ser = pd.Series(data)
-        # smaller_ser = pd.Series(data[:5])
-        # na_ser = pd.Series(type(data)._from_sequence([na_value], dtype=data.dtype))
-
-        # assert ser.equals(ser)
-        # assert na_ser.equals(na_ser)
-
-        # assert not data.equals(na_value)
-        # assert not na_ser.equals(ser)
-        # assert not ser.equals(na_ser)
-        # assert not ser.equals(smaller_ser)
-        # assert not ser.equals(np.asarray(data))
-        # assert not ser.equals(0)
-        # assert not na_ser.equals(0)

pandas/tests/extension/json/test_json.py

@@ -248,7 +248,7 @@ def test_searchsorted(self, data_for_sorting):
         super().test_searchsorted(data_for_sorting)
 
     @pytest.mark.skip(reason="Can't compare dicts.")
-    def test_equals(self, data, na_value):
+    def test_equals(self, data, na_value, as_series):
         pass
 
 

pandas/tests/extension/test_numpy.py

@@ -262,9 +262,9 @@ def test_diff(self, data, periods):
         return super().test_diff(data, periods)
 
     @skip_nested
-    def test_equals(self, data, na_value):
+    def test_equals(self, data, na_value, as_series):
         # Fails creating with _from_sequence
-        super().test_equals(data, na_value)
+        super().test_equals(data, na_value, as_series)
 
 
 @skip_nested

pandas/tests/extension/test_sparse.py

@@ -316,9 +316,9 @@ def test_shift_0_periods(self, data):
         data._sparse_values[0] = data._sparse_values[1]
         assert result._sparse_values[0] != result._sparse_values[1]
 
-    def test_equals(self, data, na_value):
+    def test_equals(self, data, na_value, as_series):
         self._check_unsupported(data)
-        super().test_equals(data, na_value)
+        super().test_equals(data, na_value, as_series)
 
 
 class TestCasting(BaseSparseTests, base.BaseCastingTests):