fix panic when null byte is included in filename

Author: informationsea

README.md

@@ -47,7 +47,7 @@ Example
 ![Result Image](images/simple1.png)
 
 ```rust
-let workbook = Workbook::new("target/simple1.xlsx");
+let workbook = Workbook::new("target/simple1.xlsx")?;
 let format1 = workbook.add_format().set_font_color(FormatColor::Red);
 
 let format2 = workbook

libxlsxwriter/examples/hello_spreadsheet.rs

@@ -1,7 +1,7 @@
 use xlsxwriter::{FormatAlignment, FormatColor, FormatUnderline, Workbook};
 
 fn main() -> Result<(), xlsxwriter::XlsxError> {
-    let workbook = Workbook::new("target/simple1.xlsx");
+    let workbook = Workbook::new("target/simple1.xlsx")?;
     let format1 = workbook.add_format().set_font_color(FormatColor::Red);
 
     let format2 = workbook

libxlsxwriter/src/chart/mod.rs

@@ -15,7 +15,7 @@ use super::Workbook;
 /// ```rust
 /// use xlsxwriter::*;
 /// # fn main() -> Result<(), XlsxError> {
-/// let workbook = Workbook::new("test-chart.xlsx");
+/// let workbook = Workbook::new("test-chart.xlsx")?;
 /// let mut worksheet = workbook.add_worksheet(None)?;
 /// write_worksheet(&mut worksheet)?; // write worksheet contents
 /// let mut chart = workbook.add_chart(ChartType::Column);
@@ -56,7 +56,7 @@ impl<'a> Chart<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart-add_series-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart-add_series-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -78,7 +78,7 @@ impl<'a> Chart<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart-add_series-2.xlsx");
+    /// # let workbook = Workbook::new("test-chart-add_series-2.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -100,7 +100,7 @@ impl<'a> Chart<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart-add_series-3.xlsx");
+    /// # let workbook = Workbook::new("test-chart-add_series-3.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -125,7 +125,7 @@ impl<'a> Chart<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart-add_series-4.xlsx");
+    /// # let workbook = Workbook::new("test-chart-add_series-4.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -148,7 +148,7 @@ impl<'a> Chart<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart-add_series-5.xlsx");
+    /// # let workbook = Workbook::new("test-chart-add_series-5.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);

libxlsxwriter/src/chart/series.rs

@@ -17,7 +17,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_categories-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_categories-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -85,7 +85,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_name-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_name-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -111,7 +111,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_name-2.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_name-2.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -146,7 +146,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_name_range-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_name_range-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -188,7 +188,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_line-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_line-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -226,7 +226,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_fill-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_fill-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -268,7 +268,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_invert_if_negative-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_invert_if_negative-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -316,7 +316,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_pattern-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_pattern-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Column);
@@ -353,7 +353,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_marker-type-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_marker-type-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);
@@ -383,7 +383,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_marker-type-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_marker-type-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);
@@ -411,7 +411,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_marker-line-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_marker-line-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);
@@ -447,7 +447,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_marker-fill-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_marker-fill-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);
@@ -488,7 +488,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_smooth-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_smooth-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);
@@ -518,7 +518,7 @@ impl<'a> ChartSeries<'a> {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// # let workbook = Workbook::new("test-chart_series-set_labels-1.xlsx");
+    /// # let workbook = Workbook::new("test-chart_series-set_labels-1.xlsx")?;
     /// # let mut worksheet = workbook.add_worksheet(None)?;
     /// # write_worksheet(&mut worksheet)?; // write worksheet contents
     /// # let mut chart = workbook.add_chart(ChartType::Line);

libxlsxwriter/src/lib.rs

@@ -29,7 +29,7 @@
 //! use xlsxwriter::*;
 //!
 //! # fn main() -> Result<(), XlsxError> {
-//! let workbook = Workbook::new("simple1.xlsx");
+//! let workbook = Workbook::new("simple1.xlsx")?;
 //! let mut format1 = workbook.add_format()
 //!     .set_font_color(FormatColor::Red);
 //!

libxlsxwriter/src/test.rs

@@ -2,7 +2,7 @@ use super::*;
 
 #[test]
 fn test_simple1() -> Result<(), XlsxError> {
-    let workbook = Workbook::new("../target/simple1.xlsx");
+    let workbook = Workbook::new("../target/simple1.xlsx")?;
     let format1 = workbook.add_format().set_font_color(FormatColor::Red);
 
     let format2 = workbook
@@ -37,7 +37,7 @@ fn test_simple1() -> Result<(), XlsxError> {
 
 #[test]
 fn test_sample1() -> Result<(), XlsxError> {
-    let workbook = Workbook::new("../target/test.xlsx");
+    let workbook = Workbook::new("../target/test.xlsx")?;
 
     let format1 = workbook
         .add_format()
@@ -86,7 +86,7 @@ fn test_sample1() -> Result<(), XlsxError> {
 
 #[test]
 fn test_add_table1() -> Result<(), XlsxError> {
-    let workbook = Workbook::new("test-worksheet_add_table-2.xlsx");
+    let workbook = Workbook::new("test-worksheet_add_table-2.xlsx")?;
     let mut worksheet = workbook.add_worksheet(None)?;
     worksheet.write_string(0, 0, "header 1", None)?;
     worksheet.write_string(0, 1, "header 2", None)?;
@@ -117,7 +117,7 @@ fn test_add_table1() -> Result<(), XlsxError> {
 
 #[test]
 fn test_add_table2() -> Result<(), XlsxError> {
-    let workbook = Workbook::new("test-worksheet_add_table-3.xlsx");
+    let workbook = Workbook::new("test-worksheet_add_table-3.xlsx")?;
     let mut worksheet = workbook.add_worksheet(None)?;
     worksheet.write_string(0, 0, "header 1", None)?;
     worksheet.write_string(0, 1, "header 2", None)?;

libxlsxwriter/src/workbook.rs

@@ -12,7 +12,7 @@ use std::rc::Rc;
 /// ```rust
 /// use xlsxwriter::*;
 /// fn main() -> Result<(), XlsxError> {
-///     let workbook = Workbook::new("test-workbook.xlsx");
+///     let workbook = Workbook::new("test-workbook.xlsx")?;
 ///     let mut worksheet = workbook.add_worksheet(None)?;
 ///     worksheet.write_string(0, 0, "Hello Excel", None)?;
 ///     workbook.close()
@@ -44,17 +44,17 @@ impl Workbook {
 
     /// This function is used to create a new Excel workbook with a given filename.
     /// When specifying a filename it is recommended that you use an .xlsx extension or Excel will generate a warning when opening the file.
-    pub fn new(filename: &str) -> Workbook {
+    pub fn new(filename: &str) -> Result<Workbook, XlsxError> {
         unsafe {
-            let workbook_name = Box::pin(CString::new(filename).expect("Null Error"));
+            let workbook_name = Box::pin(CString::new(filename)?);
             let raw_workbook = libxlsxwriter_sys::workbook_new(workbook_name.as_ptr());
             if raw_workbook.is_null() {
                 unreachable!()
             }
-            Workbook {
+            Ok(Workbook {
                 workbook: raw_workbook,
                 const_str: Rc::new(RefCell::new(vec![workbook_name])),
-            }
+            })
         }
     }
 
@@ -214,7 +214,7 @@ impl Workbook {
     /// ```rust
     /// # use xlsxwriter::*;
     /// # fn main() -> Result<(), XlsxError> {
-    /// let workbook = Workbook::new("test-workbook-define_name.xlsx");
+    /// let workbook = Workbook::new("test-workbook-define_name.xlsx")?;
     /// let mut worksheet = workbook.add_worksheet(None)?;
     /// workbook.define_name("Exchange_rate", "=0.95");
     /// worksheet.write_formula(0, 0, "=Exchange_rate", None);

libxlsxwriter/src/worksheet/filter.rs

@@ -231,7 +231,7 @@ mod test {
 
     #[test]
     fn test_autofilter() -> Result<(), XlsxError> {
-        let workbook = Workbook::new("test-worksheet_autofilter.xlsx");
+        let workbook = Workbook::new("test-worksheet_autofilter.xlsx")?;
         // ------------
         let mut worksheet1 = workbook.add_worksheet(Some("Sheet 1"))?;
         create_sheet(&mut worksheet1)?;