refactor(compiler): remove WalkingCompiler and WalkingViewFactory

Author: vsavkin

lib/core_dom/module_internal.dart

@@ -50,7 +50,6 @@ part 'transcluding_component_factory.dart';
 part 'tree_sanitizer.dart';
 part 'view.dart';
 part 'view_factory.dart';
-part 'walking_compiler.dart';
 part 'web_platform.dart';
 
 class CoreDomModule extends Module {

lib/core_dom/view_factory.dart

@@ -26,100 +26,6 @@ abstract class ViewFactory implements Function {
   View call(Scope scope, DirectiveInjector directiveInjector, [List<dom.Node> elements]);
 }
 
-/**
- * [WalkingViewFactory] is used to create new [View]s. WalkingViewFactory is
- * created by the [Compiler] as a result of compiling a template.
- */
-class WalkingViewFactory implements ViewFactory {
-  final List<ElementBinderTreeRef> elementBinders;
-  final List<dom.Node> templateElements;
-  final Profiler _perf;
-  final Expando _expando;
-
-  WalkingViewFactory(this.templateElements, this.elementBinders, this._perf,
-                     this._expando) {
-    assert(elementBinders.every((ElementBinderTreeRef eb) =>
-        eb is ElementBinderTreeRef));
-  }
-
-  BoundViewFactory bind(DirectiveInjector directiveInjector) =>
-      new BoundViewFactory(this, directiveInjector);
-
-  View call(Scope scope, DirectiveInjector directiveInjector, [List<dom.Node> nodes]) {
-    assert(directiveInjector != null);
-    if (nodes == null) nodes = cloneElements(templateElements);
-    var timerId;
-    try {
-      assert((timerId = _perf.startTimer('ng.view')) != false);
-      EventHandler eventHandler =  directiveInjector.getByKey(EVENT_HANDLER_KEY);
-      Animate animate = directiveInjector.getByKey(ANIMATE_KEY);
-      var view = new View(nodes, scope, eventHandler);
-      _link(view, scope, nodes, elementBinders, eventHandler, animate, directiveInjector);
-      return view;
-    } finally {
-      assert(_perf.stopTimer(timerId) != false);
-    }
-  }
-
-  View _link(View view, Scope scope, List<dom.Node> nodeList, List elementBinders,
-             EventHandler eventHandler, Animate animate,
-             DirectiveInjector directiveInjector) {
-
-    var preRenderedIndexOffset = 0;
-    var directiveDefsByName = {};
-
-    for (int i = 0; i < elementBinders.length; i++) {
-      // querySelectorAll('.ng-binding') should return a list of nodes in the
-      // same order as the elementBinders list.
-
-      // keep a injector array --
-
-      var eb = elementBinders[i];
-      int index = eb.offsetIndex;
-
-      ElementBinderTree tree = eb.subtree;
-
-      //List childElementBinders = eb.childElementBinders;
-      int nodeListIndex = index + preRenderedIndexOffset;
-      dom.Node node = nodeList[nodeListIndex];
-      var binder = tree.binder;
-
-      var timerId;
-      try {
-        assert((timerId = _perf.startTimer('ng.view.link', _html(node))) != false);
-        // if node isn't attached to the DOM, create a parent for it.
-        var parentNode = node.parentNode;
-        var fakeParent = false;
-        if (parentNode == null) {
-          fakeParent = true;
-          parentNode = new dom.DivElement()..append(node);
-        }
-
-        DirectiveInjector childInjector;
-        if (binder == null) {
-          childInjector = directiveInjector;
-        } else {
-          childInjector = binder.bind(view, scope, directiveInjector, node, eventHandler, animate);
-
-          // TODO(misko): Remove this after we remove controllers. No controllers -> 1to1 Scope:View.
-          if (childInjector != directiveInjector) scope = childInjector.scope;
-        }
-        if (fakeParent) {
-          // extract the node from the parentNode.
-          nodeList[nodeListIndex] = parentNode.nodes[0];
-        }
-
-        if (tree.subtrees != null) {
-          _link(view, scope, node.nodes, tree.subtrees, eventHandler, animate, childInjector);
-        }
-      } finally {
-        assert(_perf.stopTimer(timerId) != false);
-      }
-    }
-    return view;
-  }
-}
-
 /**
  * ViewCache is used to cache the compilation of templates into [View]s.
  * It can be used synchronously if HTML is known or asynchronously if the

lib/core_dom/walking_compiler.dart

@@ -5,14 +5,6 @@ import 'package:angular/core_dom/directive_injector.dart';
 
 
 forBothCompilers(fn) {
-  describe('walking compiler', () {
-    beforeEachModule((Module m) {
-      m.bind(Compiler, toImplementation: WalkingCompiler);
-      return m;
-    });
-    fn('walking');
-  });
-
   describe('tagging compiler', () {
     beforeEachModule((Module m) {
       m.bind(Compiler, toImplementation: TaggingCompiler);

test/core_dom/compiler_spec.dart

@@ -2,6 +2,7 @@ library view_spec;
 
 import '../_specs.dart';
 import 'package:angular/application_factory.dart';
+import 'package:angular/core_dom/static_keys.dart';
 
 class Log {
   List<String> log = <String>[];
@@ -61,7 +62,6 @@ class BFormatter {
 
 
 main() {
-  var viewFactoryFactory = (a,b,c,d) => new WalkingViewFactory(a,b,c,d);
   describe('View', () {
     ViewPort viewPort;
     Element rootElement;
@@ -73,15 +73,20 @@ main() {
 
     describe('mutation', () {
       var a, b;
-      var expando = new Expando();
+
+      View createView(Injector injector, String html) {
+        final scope = injector.get(Scope);
+        final c = injector.get(Compiler);
+        return c(es(html), injector.get(DirectiveMap))(scope, injector.get(DirectiveInjector));
+      }
 
       beforeEach((Injector injector, Profiler perf) {
         rootElement.innerHtml = '<!-- anchor -->';
         var scope = injector.get(Scope);
         viewPort = new ViewPort(injector.get(DirectiveInjector), scope, rootElement.childNodes[0],
           injector.get(Animate));
-        a = (viewFactoryFactory(es('<span>A</span>a'), [], perf, expando))(scope, injector.get(DirectiveInjector));
-        b = (viewFactoryFactory(es('<span>B</span>b'), [], perf, expando))(scope, injector.get(DirectiveInjector));
+        a = createView(injector, "<span>A</span>a");
+        b = createView(injector, "<span>B</span>b");
       });