fix(select): respect tracking expression when shallow watching arrays of objects in ngOptions

ngOptions does not use the tracking expression when shallow watching array elements passed in to ngOptions. This is a problem if the elements passed in to ngOptions are generated on the fly and while the array elements identical in value, they are different instances; this leads to infinite digest loops. This change attempts to rectify the situation by shallow watching an array of trackFn(values) rather than the array of values themselves.

Closes angular#9464

Author: drjokepu

src/ng/directive/select.js

@@ -403,7 +403,23 @@ var selectDirective = ['$compile', '$parse', function($compile,   $parse) {
 
         ctrl.$render = render;
 
-        scope.$watchCollection(valuesFn, render);
+        if (trackFn) {
+          scope.$watchCollection(function() {
+            var locals = {},
+                values = valuesFn(scope);
+            if (values) {
+              var trackers = new Array(values.length);
+              for (var i = 0, ii = values.length; i < ii; i++) {
+                trackers[i] = trackFn(scope, locals);
+              }
+
+              return trackers;
+            }
+          }, render);
+        } else {
+          scope.$watchCollection(valuesFn, render);
+        }
+
         scope.$watchCollection(function () {
           var locals = {},
               values = valuesFn(scope);
@@ -570,7 +586,7 @@ var selectDirective = ['$compile', '$parse', function($compile,   $parse) {
 
                 // if it's a null option
                 if (option.id === '' && nullOption) {
-                  // put back the pre-compiled element
+                  // put back the pre-compwailed element
                   element = nullOption;
                 } else {
                   // jQuery(v1.4.2) Bug: We should be able to chain the method calls, but

test/ng/directive/selectSpec.js

@@ -1130,6 +1130,29 @@ describe('select', function() {
         expect(element.val()).toEqual('?');
         expect(countSelected()).toEqual(1);
       });
+
+      it('should respect trackexpr when working with arrays of objects', function() {
+        var elementCount = 5;
+
+        createSelect({
+          'ng-model':'selected',
+          'ng-options':'v as v.label for v in makeValues() track by v.code'
+        });
+
+        scope.$apply(function() {
+          scope.makeValues = function() {
+            var values = [];
+            for (var i = 0; i < elementCount; i++) {
+              values.push({label: 'Value = ' + i, code: i});
+            }
+
+            return values;
+          };
+          scope.selected = {label: 'Value = 1', code: 1};
+        });
+
+        expect(element.find('option').length).toEqual(elementCount);
+      });
     });