Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Commit 1517b06

Browse files
committed
fix(logging): remove unnecessary websocket error msg, clean up copy error msg
remove unnecessary websocket error msg, clean up copy error msg
1 parent 3ec5103 commit 1517b06

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/copy.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export function copyUpdate(event: string, filePath: string, context: BuildContex
3838
return copySrcToDest(context, copyOptions.src, copyOptions.dest, copyOptions.filter, true);
3939
});
4040
return Promise.all(promises).then((copySrcToDestResults: CopySrcToDestResult[]) => {
41-
printCopyErrorMessages('copy', copySrcToDestResults);
41+
printCopyErrorMessages(copySrcToDestResults);
4242
const destFiles = copySrcToDestResults.map(copySrcToDestResult => copySrcToDestResult.dest);
4343
emit(EventType.FileChange, destFiles);
4444
});
@@ -76,14 +76,14 @@ export function copyWorker(context: BuildContext, configFile: string) {
7676
});
7777

7878
return Promise.all(promises).then((copySrcToDestResults: CopySrcToDestResult[]) => {
79-
printCopyErrorMessages('copy', copySrcToDestResults);
79+
printCopyErrorMessages(copySrcToDestResults);
8080
});
8181
}
8282

83-
function printCopyErrorMessages(prefix: string, copyResults: CopySrcToDestResult[]) {
83+
function printCopyErrorMessages(copyResults: CopySrcToDestResult[]) {
8484
copyResults.forEach(copyResult => {
8585
if (!copyResult.success) {
86-
Logger.warn(`${prefix}: ${copyResult.errorMessage}`);
86+
Logger.warn(copyResult.errorMessage);
8787
}
8888
});
8989
}

src/dev-server/notification-server.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ export function createNotificationServer(config: ServeConfig) {
2626
try {
2727
wsServer.send(JSON.stringify(msg));
2828
} catch (e) {
29-
Logger.error(`error sending client ws, ${e}`);
29+
if (e.message !== 'not opened') {
30+
Logger.error(`error sending client ws - ${e.message}`);
31+
}
3032
}
3133
}
3234
}

0 commit comments

Comments
 (0)