We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent cfd57f2 commit b8912f7Copy full SHA for b8912f7
kafka/coordinator/base.py
@@ -990,6 +990,11 @@ def _run_once(self):
990
# foreground thread has stalled in between calls to
991
# poll(), so we explicitly leave the group.
992
log.warning('Heartbeat poll expired, leaving group')
993
+ ### XXX
994
+ # maybe_leave_group acquires client + coordinator lock;
995
+ # if we hold coordinator lock before calling, we risk deadlock
996
+ # release() is safe here because this is the last code in the current context
997
+ self.coordinator._lock.release()
998
self.coordinator.maybe_leave_group()
999
1000
elif not self.coordinator.heartbeat.should_heartbeat():
0 commit comments