Add test for named parameters from compiled classfile

Author: Kordyjan

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -42,6 +42,7 @@ class CompilationTests {
       compileFilesInDir("tests/pos-custom-args/erased", defaultOptions.and("-Yerased-terms")),
       compileFilesInDir("tests/pos", defaultOptions),
       compileFilesInDir("tests/pos-deep-subtype", allowDeepSubtypes),
+      compileDir("tests/pos-special/java-param-names", defaultOptions.withJavacOnlyOptions("-parameters")),
       compileFile(
         // succeeds despite -Xfatal-warnings because of -nowarn
         "tests/neg-custom-args/fatal-warnings/xfatalWarnings.scala",

compiler/test/dotty/tools/vulpix/TestFlags.scala

@@ -5,19 +5,23 @@ import java.io.{File => JFile}
 final case class TestFlags(
   defaultClassPath: String,
   runClassPath: String, // class path that is used when running `run` tests (not compiling)
-  options: Array[String]) {
+  options: Array[String],
+  javacOptions: Array[String]) {
 
   def and(flags: String*): TestFlags =
-    TestFlags(defaultClassPath, runClassPath, options ++ flags)
+    TestFlags(defaultClassPath, runClassPath, options ++ flags, javacOptions)
 
   def without(flags: String*): TestFlags =
-    TestFlags(defaultClassPath, runClassPath, options diff flags)
+    TestFlags(defaultClassPath, runClassPath, options diff flags, javacOptions)
 
   def withClasspath(classPath: String): TestFlags =
-    TestFlags(s"$defaultClassPath${JFile.pathSeparator}$classPath", runClassPath, options)
+    TestFlags(s"$defaultClassPath${JFile.pathSeparator}$classPath", runClassPath, options, javacOptions)
 
   def withRunClasspath(classPath: String): TestFlags =
-    TestFlags(defaultClassPath, s"$runClassPath${JFile.pathSeparator}$classPath", options)
+    TestFlags(defaultClassPath, s"$runClassPath${JFile.pathSeparator}$classPath", options, javacOptions)
+
+  def withJavacOnlyOptions(flags: String*): TestFlags =
+    TestFlags(defaultClassPath, runClassPath, options, javacOptions ++ flags)
 
   def all: Array[String] = Array("-classpath", defaultClassPath) ++ options
 
@@ -43,10 +47,10 @@ final case class TestFlags(
     val flags = all
     val cp = flags.dropWhile(_ != "-classpath").take(2)
     val output = flags.dropWhile(_ != "-d").take(2)
-    cp ++ output
+    cp ++ output ++ javacOptions
   }
 }
 
 object TestFlags {
-  def apply(classPath: String, flags: Array[String]): TestFlags = TestFlags(classPath, classPath, flags)
+  def apply(classPath: String, flags: Array[String]): TestFlags = TestFlags(classPath, classPath, flags, Array.empty)
 }

tests/pos-special/java-param-names/Foo_1.java

@@ -0,0 +1,4 @@
+public class Foo_1 {
+  public Foo_1(int number, String text) {}
+  public void bar(String barText, int barNumber) {}
+}

tests/pos-special/java-param-names/Test_2.scala

@@ -0,0 +1,2 @@
+@main def Test =
+  new Foo_1(number = 6, text = "param-name").bar(barNumber = 8, barText = "some-method")