Fix scala#3452: Fix cycle with implicit by-name parameter

When creating a lazy val to represent an implicit by-name parameter, we
need to fully define its type, otherwise cycles can arise in our
constraints.

This is similar to the issue fixed in eb2fdf2

Author: smarter

compiler/src/dotty/tools/dotc/typer/Implicits.scala

@@ -617,6 +617,7 @@ trait Implicits { self: Typer =>
      */
     val (formalValue, lazyImplicit, argCtx) = formal match {
       case ExprType(fv) =>
+        fullyDefinedType(fv, "implicit by-name parameter", pos)
         val lazyImplicit = ctx.newLazyImplicit(fv)
         (fv, lazyImplicit, lazyImplicitCtx(lazyImplicit))
       case _ => (formal, NoSymbol, ctx)

tests/neg/i3542.scala

@@ -0,0 +1,8 @@
+object Test {
+  trait TC[A]
+
+  implicit def case1[F[_]](implicit t: => TC[F[Any]]): TC[String] = ???
+  implicit def case2[G[_]](implicit r: TC[G[Any]]): TC[Int] = ???
+
+  implicitly[TC[Int]]
+}

tests/pos/i3542.scala

@@ -0,0 +1,7 @@
+class Foo[T]
+
+object Test {
+  implicit def foo[T](implicit rec: => Foo[T]): Foo[T] = ???
+
+  val bla: Foo[Int] = implicitly[Foo[Int]]
+}