Skip to content

Commit 8c6c421

Browse files
committed
Fix scala#9166: Harden check for values in patterns based on class inheritance info
1 parent 758782a commit 8c6c421

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

compiler/src/dotty/tools/dotc/typer/Typer.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3808,7 +3808,10 @@ class Typer extends Namer
38083808
mapOver(tp)
38093809
}
38103810

3811-
if tree.symbol.isOneOf(Module | Enum)
3811+
val sym = tree.symbol
3812+
3813+
// Is it certain that a value of `tree.tpe` is never a subtype of `pt`
3814+
if (!sym.info.classSymbol.isNumericValueClass || !pt.classSymbol.isNumericValueClass)
38123815
&& !(tree.tpe frozen_<:< pt) // fast track
38133816
&& !(tree.tpe frozen_<:< approx(pt))
38143817
then

tests/neg/i9166.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
object UnitTest extends App {
2+
def foo(m: Unit) = m match {
3+
case runtime.BoxedUnit.UNIT => println("ok") // error
4+
}
5+
foo(())
6+
}

0 commit comments

Comments
 (0)