Rename evalOnce to letBind

Author: OlivierBlanvillain

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -1139,7 +1139,7 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo {
   }
 
   /** Let bind `tree` unless `tree` is at least idempotent */
-  def evalOnce(tree: Tree)(within: Tree => Tree)(implicit ctx: Context): Tree =
+  def letBind(tree: Tree)(within: Tree => Tree)(implicit ctx: Context): Tree =
     letBindUnless(TreeInfo.Idempotent, tree)(within)
 
   def runtimeCall(name: TermName, args: List[Tree])(implicit ctx: Context): Tree = {

compiler/src/dotty/tools/dotc/transform/Erasure.scala

@@ -221,7 +221,7 @@ object Erasure {
               val nullTree = Literal(Constant(null))
               val unboxedNull = adaptToType(nullTree, underlying)
 
-              evalOnce(tree) { t =>
+              letBind(tree) { t =>
                 If(t.select(defn.Object_eq).appliedTo(nullTree),
                   unboxedNull,
                   unboxedTree(t))

compiler/src/dotty/tools/dotc/transform/TypeTestsCasts.scala

@@ -265,20 +265,20 @@ object TypeTestsCasts {
           case _: SingletonType =>
             expr.isInstance(testType).withSpan(tree.span)
           case OrType(tp1, tp2) =>
-            evalOnce(expr) { e =>
+            letBind(expr) { e =>
               transformTypeTest(e, tp1, flagUnrelated = false)
                 .or(transformTypeTest(e, tp2, flagUnrelated = false))
             }
           case AndType(tp1, tp2) =>
-            evalOnce(expr) { e =>
+            letBind(expr) { e =>
               transformTypeTest(e, tp1, flagUnrelated)
                 .and(transformTypeTest(e, tp2, flagUnrelated))
             }
           case defn.MultiArrayOf(elem, ndims) if isUnboundedGeneric(elem) =>
             def isArrayTest(arg: Tree) =
               ref(defn.runtimeMethodRef(nme.isArray)).appliedTo(arg, Literal(Constant(ndims)))
             if (ndims == 1) isArrayTest(expr)
-            else evalOnce(expr) { e =>
+            else letBind(expr) { e =>
               derivedTree(e, defn.Any_isInstanceOf, e.tpe)
                 .and(isArrayTest(e))
             }

compiler/src/dotty/tools/dotc/transform/VCInlineMethods.scala

@@ -68,7 +68,7 @@ class VCInlineMethods extends MiniPhase with IdentityDenotTransformer {
         val extensionMeth = extensionMethod(origMeth)
 
         if (!ctParams.isEmpty) {
-          evalOnce(qual) { ev =>
+          letBind(qual) { ev =>
             val ctArgs = ctParams.map(tparam =>
               TypeTree(tparam.typeRef.asSeenFrom(ev.tpe, origCls)))
             ref(extensionMeth)