Avoid memory leak in TypedSplice

odersky · odersky · commit 016c5d71f29b · 2017-07-17T17:58:15.000+02:00
diff --git a/compiler/src/dotty/tools/dotc/ast/untpd.scala b/compiler/src/dotty/tools/dotc/ast/untpd.scala
@@ -29,8 +29,10 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo {
   }
 
   object TypedSplice {
-    def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice =
-      new TypedSplice(tree)(ctx.owner) {}
+    def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice = {
+      val curOwner = ctx.owner // compute here to avoid space leak with a reference from TypedSplice to Context
+      new TypedSplice(tree)(curOwner) {}
+    }
   }
 
   /** mods object name impl */

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,10 @@ object untpd extends Trees.Instance[Untyped] with UntypedTreeInfo {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`object TypedSplice {`
`32`		`- def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice =`
`33`		`- new TypedSplice(tree)(ctx.owner) {}`
	`32`	`+ def apply(tree: tpd.Tree)(implicit ctx: Context): TypedSplice = {`
	`33`	`+ val curOwner = ctx.owner // compute here to avoid space leak with a reference from TypedSplice to Context`
	`34`	`+ new TypedSplice(tree)(curOwner) {}`
	`35`	`+ }`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`/** mods object name impl */`