Skip to content

Commit f51e2ed

Browse files
author
Dondi Dionisio
committed
fix(select-choices): Possible fix for angular-ui#1355
...at the cost of potential unnecessary watches when dropdown is closed. But the premise is that, until the resulting errors are fixed, the preference is to avoid the errors for now. Closes angular-ui#1355
1 parent 8b79674 commit f51e2ed

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/uiSelectChoicesDirective.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ uis.directive('uiSelectChoices',
4444
throw uiSelectMinErr('rows', "Expected 1 .ui-select-choices-row but got '{0}'.", choices.length);
4545
}
4646

47-
choices.attr('ng-repeat', $select.parserResult.repeatExpression(groupByExp))
48-
.attr('ng-if', '$select.open'); //Prevent unnecessary watches when dropdown is closed
47+
choices.attr('ng-repeat', $select.parserResult.repeatExpression(groupByExp));
4948
if ($window.document.addEventListener) { //crude way to exclude IE8, specifically, which also cannot capture events
5049
choices.attr('ng-mouseenter', '$select.setActiveItem('+$select.parserResult.itemName +')')
5150
.attr('ng-click', '$select.select(' + $select.parserResult.itemName + ',$select.skipFocusser,$event)');

0 commit comments

Comments
 (0)