unused: don't crash on generic composite literals

(cherry picked from commit 1cd2556)

Author: dominikh

unused/testdata/src/typeparams/typeparams.go

@@ -84,3 +84,8 @@ type foo struct{} // used
 type Bar *Node[foo] // used
 
 func (n Node[T]) anyMethod() {} // unused
+
+func fn11[T ~struct{ Field int }]() { // unused
+	// don't crash because of the composite literal
+	_ = T{Field: 42}
+}

unused/unused.go

@@ -1630,12 +1630,17 @@ func (g *graph) instructions(fn *ir.Function) {
 			}
 			switch instr := instr.(type) {
 			case *ir.Field:
+				// Can't access fields via generics, for now.
+
 				st := instr.X.Type().Underlying().(*types.Struct)
 				field := st.Field(instr.Field)
 				// (4.7) functions use fields they access
 				g.seeAndUse(field, fnObj, edgeFieldAccess)
 			case *ir.FieldAddr:
-				st := typeutil.Dereference(instr.X.Type()).Underlying().(*types.Struct)
+				// User code can't access fields on type parameters, but composite literals are still possible, which
+				// compile to FieldAddr + Store.
+
+				st := typeutil.CoreType(typeutil.Dereference(instr.X.Type())).(*types.Struct)
 				field := st.Field(instr.Field)
 				// (4.7) functions use fields they access
 				g.seeAndUse(field, fnObj, edgeFieldAccess)