_notifyPWM may be called indirectly from ISR, cannot yield() from ISR, must not panic.

dok-net · dok-net · commit b64622d303d1 · 2021-10-06T07:41:59.000+02:00
diff --git a/cores/esp8266/core_esp8266_waveform_pwm.cpp b/cores/esp8266/core_esp8266_waveform_pwm.cpp
@@ -40,6 +40,7 @@
 
 
 #include <Arduino.h>
+#include <coredecls.h>
 #include "ets_sys.h"
 #include "core_esp8266_waveform.h"
 #include "user_interface.h"
@@ -162,7 +163,7 @@ static IRAM_ATTR void _notifyPWM(PWMState *p, bool idle) {
   forceTimerInterrupt();
   while (pwmState.pwmUpdate) {
     if (idle) {
-      yield();
+      esp_break();
     }
     MEMBARRIER();
   }

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@`
`40`	`40`
`41`	`41`
`42`	`42`	`#include <Arduino.h>`
	`43`	`+#include <coredecls.h>`
`43`	`44`	`#include "ets_sys.h"`
`44`	`45`	`#include "core_esp8266_waveform.h"`
`45`	`46`	`#include "user_interface.h"`
`@@ -162,7 +163,7 @@ static IRAM_ATTR void _notifyPWM(PWMState *p, bool idle) {`
`162`	`163`	`forceTimerInterrupt();`
`163`	`164`	`while (pwmState.pwmUpdate) {`
`164`	`165`	`if (idle) {`
`165`		`- yield();`
	`166`	`+ esp_break();`
`166`	`167`	`}`
`167`	`168`	`MEMBARRIER();`
`168`	`169`	`}`