Uninitialized stack object can have unintended bad values

dok-net · dok-net · commit a0fbaedb5399 · 2019-11-27T12:23:56.000+01:00
diff --git a/cores/esp8266/HardwareSerial.cpp b/cores/esp8266/HardwareSerial.cpp
@@ -133,7 +133,7 @@ unsigned long HardwareSerial::testBaudrate()
 unsigned long HardwareSerial::detectBaudrate(time_t timeoutMillis)
 {
     esp8266::polledTimeout::oneShotFastMs timeOut(timeoutMillis);
-    unsigned long detectedBaudrate;
+    unsigned long detectedBaudrate = 0;
     while (!timeOut) {
         if ((detectedBaudrate = testBaudrate())) {
           break;

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ unsigned long HardwareSerial::testBaudrate()`
`133`	`133`	`unsigned long HardwareSerial::detectBaudrate(time_t timeoutMillis)`
`134`	`134`	`{`
`135`	`135`	`esp8266::polledTimeout::oneShotFastMs timeOut(timeoutMillis);`
`136`		`- unsigned long detectedBaudrate;`
	`136`	`+ unsigned long detectedBaudrate = 0;`
`137`	`137`	`while (!timeOut) {`
`138`	`138`	`if ((detectedBaudrate = testBaudrate())) {`
`139`	`139`	`break;`